src/robots.txt.ejs: remove blank line comments - #5990
Merged
Conversation
Remove comment about blank lines not being allowed. This may have been true at one point, but recent verification with Google's own robotstxt tool shows no difference in parsing with or without the blank lines. Also, the RFC for the Robots Exclusion Protocol does not mention such a limitation. See: https://github.com/google/robotstxt See: https://www.rfc-editor.org/rfc/rfc9309.html
alanorth
added
component: SEO
tdonohue
self-requested a review
July 24, 2026 12:22
github-project-automation
Bot
moved this from 👀 Under Review
to 👍 Reviewer Approved
in DSpace 11.0 Release
github-project-automation
Bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 11.0 Release
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
Member
|
I've updated our SEO Docs for 10.x/9.x/8.x to remove the guidelines about blank lines. See for example: https://wiki.lyrasis.org/spaces/DSDOC10x/pages/408945748/Search+Engine+Optimization#SearchEngineOptimization-Createagoodrobots.txt |
tdonohue
removed
needs documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove comment about blank lines not being allowed. This may have been true at one point, but recent verification with Google's own robotstxt tool shows no difference in parsing with or without the blank lines. Also, the RFC for the Robots Exclusion Protocol does not mention such a limitation.
Note: the SEO pages on the wiki need to be updated as well, as they contain a snippet from our robots.txt with this comment.
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
As this is a very minor pull request, the best way to test it is to review the changes and review the linked documentation to see if it makes sense.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.