tr_shader: rework the non-delayed texture loading, fix loading legacy diffuse stage#1918
Open
illwieckz wants to merge 1 commit intofor-0.56.0/syncfrom
Open
tr_shader: rework the non-delayed texture loading, fix loading legacy diffuse stage#1918illwieckz wants to merge 1 commit intofor-0.56.0/syncfrom
illwieckz wants to merge 1 commit intofor-0.56.0/syncfrom
Conversation
Member
Author
|
Before:
After:
|
Member
|
This breaks something with Xonotic normal or height maps. Before: After: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it was clever to detect a non-delayed legacy stage was one because the bundle index was
TB_COLORMAP, but then it means every legacy diffuse stage is seen as delayed and non-legacy, becauseTB_DIFFUSEMAPequalsTB_COLORMAP(and that is wanted). So all legacy stage textures loaded properly (normal map, specular map) but the color map.So I reworked that to fix the bug and make the code nicer.