Detect Zhaoxin GPU, disable realtime lighting on it#1968
Merged
Conversation
illwieckz
force-pushed
the
illwieckz/zhaoxin
branch
from
674454f to
9d1f0e5
Compare
slipher
reviewed
May 9, 2026
| size_t prefixLen = prefix.length(); | ||
| size_t stringLen = string.length(); | ||
| size_t subLen = stringLen - prefixLen; | ||
| return string.substr( prefixLen, subLen ); |
Member
There was a problem hiding this comment.
The 2nd argument to substr is unneeded. You can put the starting position only
| ================================================================================= | ||
| */ | ||
|
|
||
| static void EnableAvailableFeatures() |
Member
There was a problem hiding this comment.
The next 5 functions below this one are also frontend...
Member
Author
There was a problem hiding this comment.
Yeah maybe, but I moved this one because I needed it elsewhere right now. The rest can be moved later. =)
Actually I may restore the comment.
Member
Author
There was a problem hiding this comment.
Restored the comment and adapted it.
illwieckz
force-pushed
the
illwieckz/zhaoxin
branch
2 times, most recently
from
854841f to
4f55c5b
Compare
Member
|
LGTM |
Member
Author
|
GitHub says the Appveyor check is still pending, but it's finished and without error on Appveyor side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnableAvailableFeatures()fromtr_sharetosdl_glimpBroken real time lights on ZX C-1190 (integrated graphics from Zhaoxin KX-7000) #1967
To avoid annoying merge conflicts, this also include GL4ES detection (but not the GL4ES compatibility code) and PowerVR detection from:
fix #1967