Skip to content

debugging: implement r_showNormalMaps and r_showMaterialMaps#257

Merged
illwieckz merged 3 commits intoDaemonEngine:masterfrom
illwieckz:debug
Jan 9, 2020
Merged

debugging: implement r_showNormalMaps and r_showMaterialMaps#257
illwieckz merged 3 commits intoDaemonEngine:masterfrom
illwieckz:debug

Conversation

@illwieckz
Copy link
Copy Markdown
Member

@illwieckz illwieckz commented Dec 29, 2019

implement r_showNormalMaps

r_showEntityNormals is dropped, in any way, vertexLighting_DBS_entity
and vertexLighting_DBS_world glsl are asking for merge

also beautify some code for other r_show* cvar

also introduce r_showMaterialMaps to debug specular and physical maps.

@illwieckz illwieckz added T-Improvement Improvement for an existing feature A-Renderer labels Dec 29, 2019
@illwieckz illwieckz changed the title debugging: implement r_showNormalMaps debugging: implement r_showNormalMaps and r_showMaterialMaps Dec 29, 2019
@illwieckz
Copy link
Copy Markdown
Member Author

I was having problems with specular maps, so I added r_showMaterialMaps… This to discover a mistake I did… and to somwhat fix PBR in the process…

@illwieckz
Copy link
Copy Markdown
Member Author

I would like to merge #256 before this one so I can also implement r_normalMapping in liquid shader.

Copy link
Copy Markdown
Member

@slipher slipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A warning message if 2 or more of these mutually exclusive cvars are enabled would be nice. Otherwise looks good to merge.

@illwieckz
Copy link
Copy Markdown
Member Author

rebased on master and implemented r_showNormalMaps on liquidmap_fp.glsl

@illwieckz
Copy link
Copy Markdown
Member Author

@slipher A warning message if 2 or more of these mutually exclusive cvars are enabled would be nice. Otherwise looks good to merge.

I would like to have such feature but that seems not be very easy to do, as we may test all conflicting options…

A better implementation would be something like `r_showDebug normalmaps' or something like that, with a number for each type. We may create an issue for this but to me that looks out of topic of this PR.

also, it may be a physical map and not only a specular one
r_showEntityNormals is dropped, in any way, vertexLighting_DBS_entity
and vertexLighting_DBS_world glsl are asking for merge

also beautify some code for other r_show* cvar
@illwieckz illwieckz merged commit 8d05a50 into DaemonEngine:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Renderer T-Improvement Improvement for an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants