crnlib: correct alternate code to test if a path is a directory#64
Merged
crnlib: correct alternate code to test if a path is a directory#64
Conversation
The alternate code was testing for the file name in the current directory.
1961276 to
ac13061
Compare
ac13061 to
1d4cbb3
Compare
ea9ba2b to
d2e90f9
Compare
d2e90f9 to
8118010
Compare
Member
Author
|
One may open the folder with |
Member
Author
|
Also an alternate code to use
So this may be the fastest code. |
8118010 to
6927e86
Compare
slipher
reviewed
Jul 9, 2024
6927e86 to
62b5939
Compare
slipher
reviewed
Jul 10, 2024
crnlib/crn_find_files.cpp
Outdated
| bool is_file = 0; | ||
| bool is_directory = false; | ||
| bool is_file = false; | ||
| bool guessed = false; |
Member
There was a problem hiding this comment.
I would call it known. The word "guess" implies you are making the answer and don't know it it's correct.
62b5939 to
571aa58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alternate code was testing for the file name in the current directory.
Fixes #63: