Skip to content

Discard extra sections linking nacl_helper_bootstrap #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slipher merged 1 commit into from
Dec 18, 2025
+4 −2
Merged

Discard extra sections linking nacl_helper_bootstrap #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/trusted/service_runtime/build.scons
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@ if (env.Bit('linux') and not env.Bit('built_elsewhere')):
[bootstrap_obj],
("env CXX='${CXX}' ${PYTHON} %s %s " +
'-m %s --build-id -static -z max-page-size=0x1000 ' +
'--orphan-handling=discard ' +
'--defsym RESERVE_TOP=%s --script %s -o ${TARGET} ${SOURCES}') %
(bootstrap_env.File('linux/ld_bfd.py'), compiler_override, ld_emul,
reserve_top, bootstrap_env.File('linux/nacl_bootstrap.x')),
Expand Down
5 changes: 3 additions & 2 deletions src/trusted/service_runtime/linux/nacl_bootstrap.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
*
* This is a custom linker script used to build nacl_helper_bootstrap.
* It has a very special layout. This script will only work with input
* that is kept extremely minimal. If there are unexpected input sections
* not named here, the result will not be correct.
* that is kept extremely minimal. Unexpected input sections will be
* discarded so if there are unexpected input sections not named here which
* are actually important, the result will not be correct.
*
* We need to use a standalone loader program rather than just using a
* dynamically-linked program here because its entire address space will be
Expand Down