Discard extra sections linking nacl_helper_bootstrap #10
Conversation
Use --orphan-handling=unwanted when linking nacl_helper_bootstrap which makes the linker discard any sections not explicitly mentioned in the linker script. This prevents the linker from producing a defective binary with overlapping PT_LOAD headers when using GCC on certain distros such as Ubuntu and Arch that have it configured to produce a .note.gnu.property section
illwieckz
left a comment
illwieckz
left a comment
There was a problem hiding this comment.
LGTM.
Though I don't know what to do with the BUILD.gn file we don't use.
Hmm I never really paid attention to those. Apparently both build systems are still maintained upstream which is bizarre. |
I suspect that the BUILD.gn system isn't usable outside of the Chromium build system, and as it is written right now cannot be used to build a standalone nacl loader (at least I failed to achieve that when I tested them), while the SCons scripts makes it possible to build and test a standalone loader. |
One way of working around the linker bug from #6. Also makes the binary smaller