Adding ticket ID to last TODO

[gouri-yerra]

What does this PR do?

grep -r '//\s*TODO' --include="*.go" | grep 'pkg/logs\|comp/logs'
./pkg/logs/tailers/windowsevent/tailer_test.go:	// TODO: https://datadoghq.atlassian.net/browse/WINA-480
./pkg/logs/util/windowsevent/transform.go:	// TODO: compat: binary data is not guaranteed to be a utf-16 string, but go's
./pkg/logs/internal/tag/provider.go:		// TODO: remove this once AD and Tagger use the same PodWatcher instance

Adding the ticket ID to the TODO in tag/provider?
ex:
// TODO AGNTLOG-475: remove this once AD and Tagger use the same PodWatcher instance

Motivation

We are almost TODO free!

Describe how you validated your changes

Linter check

Additional Notes

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 5821a14
📊 Static Quality Gates Dashboard

31 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	705.502 MiB
✅	agent_deb_amd64_fips	700.787 MiB
✅	agent_heroku_amd64	326.527 MiB
✅	agent_msi	570.926 MiB
✅	agent_rpm_amd64	705.488 MiB
✅	agent_rpm_amd64_fips	700.774 MiB
✅	agent_rpm_arm64	686.999 MiB
✅	agent_rpm_arm64_fips	683.140 MiB
✅	agent_suse_amd64	705.488 MiB
✅	agent_suse_amd64_fips	700.774 MiB
✅	agent_suse_arm64	686.999 MiB
✅	agent_suse_arm64_fips	683.140 MiB
✅	docker_agent_amd64	767.236 MiB
✅	docker_agent_arm64	773.367 MiB
✅	docker_agent_jmx_amd64	958.115 MiB
✅	docker_agent_jmx_arm64	952.965 MiB
✅	docker_cluster_agent_amd64	180.761 MiB
✅	docker_cluster_agent_arm64	196.618 MiB
✅	docker_cws_instrumentation_amd64	7.135 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	38.785 MiB
✅	docker_dogstatsd_arm64	37.065 MiB
✅	dogstatsd_deb_amd64	30.004 MiB
✅	dogstatsd_deb_arm64	28.152 MiB
✅	dogstatsd_rpm_amd64	30.004 MiB
✅	dogstatsd_suse_amd64	30.004 MiB
✅	iot_agent_deb_amd64	42.998 MiB
✅	iot_agent_deb_arm64	40.119 MiB
✅	iot_agent_deb_armhf	40.704 MiB
✅	iot_agent_rpm_amd64	42.999 MiB
✅	iot_agent_suse_amd64	42.999 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-50.82 KiB (0.03% reduction)	173.402 → 173.352 → 174.490
✅	agent_deb_amd64_fips	+36.08 KiB (0.02% increase)	172.341 → 172.376 → 173.750
✅	agent_heroku_amd64	neutral	87.061 MiB
✅	agent_msi	neutral	142.750 MiB
✅	agent_rpm_amd64	+12.5 KiB (0.01% increase)	176.027 → 176.039 → 177.660
✅	agent_rpm_amd64_fips	+15.35 KiB (0.01% increase)	175.152 → 175.167 → 176.600
✅	agent_rpm_arm64	+33.58 KiB (0.02% increase)	159.438 → 159.471 → 161.260
✅	agent_rpm_arm64_fips	-82.97 KiB (0.05% reduction)	158.889 → 158.808 → 160.550
✅	agent_suse_amd64	+12.5 KiB (0.01% increase)	176.027 → 176.039 → 177.660
✅	agent_suse_amd64_fips	+15.35 KiB (0.01% increase)	175.152 → 175.167 → 176.600
✅	agent_suse_arm64	+33.58 KiB (0.02% increase)	159.438 → 159.471 → 161.260
✅	agent_suse_arm64_fips	-82.97 KiB (0.05% reduction)	158.889 → 158.808 → 160.550
✅	docker_agent_amd64	neutral	261.024 MiB
✅	docker_agent_arm64	neutral	250.049 MiB
✅	docker_agent_jmx_amd64	neutral	329.664 MiB
✅	docker_agent_jmx_arm64	+2.59 KiB (0.00% increase)	314.668 → 314.670 → 317.270
✅	docker_cluster_agent_amd64	neutral	63.854 MiB
✅	docker_cluster_agent_arm64	neutral	60.143 MiB
✅	docker_cws_instrumentation_amd64	neutral	2.994 MiB
✅	docker_cws_instrumentation_arm64	neutral	2.726 MiB
✅	docker_dogstatsd_amd64	neutral	15.014 MiB
✅	docker_dogstatsd_arm64	neutral	14.341 MiB
✅	dogstatsd_deb_amd64	neutral	7.938 MiB
✅	dogstatsd_deb_arm64	neutral	6.814 MiB
✅	dogstatsd_rpm_amd64	neutral	7.949 MiB
✅	dogstatsd_suse_amd64	neutral	7.949 MiB
✅	iot_agent_deb_amd64	neutral	11.263 MiB
✅	iot_agent_deb_arm64	neutral	9.631 MiB
✅	iot_agent_deb_armhf	neutral	9.826 MiB
✅	iot_agent_rpm_amd64	neutral	11.278 MiB
✅	iot_agent_suse_amd64	neutral	11.278 MiB

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9460b90a-a9ec-4b57-a0f3-74feaedb9fd2

Baseline: 5821a14
Comparison: f73d7af
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-2.09	[-4.99, +0.81]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+3.38	[+1.88, +4.88]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulative	memory utilization	+0.49	[+0.33, +0.65]	1	Logs
➖	ddot_logs	memory utilization	+0.21	[+0.14, +0.28]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.11	[-0.12, +0.35]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.05	[+0.00, +0.10]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.02	[-0.38, +0.42]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.02	[-0.35, +0.39]	1	Logs
➖	ddot_metrics	memory utilization	+0.01	[-0.20, +0.22]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.12, +0.13]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.08, +0.08]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.00	[-0.12, +0.12]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.43, +0.41]	1	Logs
➖	file_tree	memory utilization	-0.02	[-0.07, +0.03]	1	Logs
➖	docker_containers_memory	memory utilization	-0.05	[-0.12, +0.02]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.06	[-0.22, +0.09]	1	Logs
➖	quality_gate_idle	memory utilization	-0.30	[-0.35, -0.25]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.34	[-0.38, -0.31]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.39	[-0.50, -0.28]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.46	[-0.67, -0.25]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	-0.47	[-0.58, -0.36]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.55	[-0.75, -0.34]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.81	[-0.86, -0.75]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-2.09	[-4.99, +0.81]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.