Skip to content

Add tailscale in devcontainer - #54896

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
kfairise/tailscale-in-devcontainer
Aug 17, 2026
Merged

Add tailscale in devcontainer#54896
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
kfairise/tailscale-in-devcontainer

Conversation

@KevinFairise2

Copy link
Copy Markdown
Member

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-devx labels Aug 14, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Aug 14, 2026
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@dd-octo-sts

dd-octo-sts Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 2f78841f:

Results for datadog-agent_7.84.0~devel.git.197.364d352.pipeline.130969593-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.197.364d352.pipeline.130969593-1_amd64.deb:

No change detected

@KevinFairise2
KevinFairise2 marked this pull request as ready for review August 14, 2026 15:02
@KevinFairise2
KevinFairise2 requested a review from a team as a code owner August 14, 2026 15:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 364d35224d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# cp /root/.local/bin/claude /home/bits/.local/bin/claude
# Install tailscale so workspace devcontainers can connect to the Headscale
# overlay network and reach agent-sandbox private VMs
curl -fsSL https://tailscale.com/install.sh | sh

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pin and verify the Tailscale installer

Every devcontainer prebuild now executes whatever tailscale.com/install.sh serves at that moment as root, so rebuilding this commit after an upstream installer or package change can produce a different—or broken—image, and a compromised response would gain root execution in the workspace image. Install a reviewed, version-pinned artifact and verify its signature or checksum instead of piping a mutable remote script directly to sh.

Useful? React with 👍 / 👎.

@temporal-github-worker-1

temporal-github-worker-1 Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

❌ Devcontainer prebuild failed.

Branch: kfairise/tailscale-in-devcontainer
Config: .devcontainer/datadog/default/prebuild-devcontainer.json

Links:

@chouetz chouetz added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Aug 17, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 99d001c into main Aug 17, 2026
288 of 300 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the kfairise/tailscale-in-devcontainer branch August 17, 2026 08:06
@github-actions github-actions Bot added this to the 7.84.0 milestone Aug 17, 2026
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 3cb1a3bd-12d9-49e3-af47-17dd6f74e9ec

Baseline: bc5edb6
Comparison: 99d001c
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.61 [+0.72, +2.49] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.28 [+0.16, +0.40] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.19 [+0.09, +0.30] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.08 [-0.16, -0.01] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.14 [-0.19, -0.10] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.24 [-0.38, -0.09] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization -0.24 [-0.36, -0.12] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -1.11 [-1.35, -0.86] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 175.33MiB ≤ 178MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 739.73KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 513.90MiB ≤ 538MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.14MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 204.07MiB ≤ 229MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.18MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 362.30 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 386.67MiB ≤ 439MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.91MiB ≤ 76MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 27.62 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 325.99MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 59.81 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 306.37MiB ≤ 314MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 20.70 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 304.83MiB ≤ 343MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants