Drop potentially misleading cache-mount hint from tools/bazel.bat - #54980
Open
rdesgroppes wants to merge 1 commit into
Open
Drop potentially misleading cache-mount hint from tools/bazel.bat#54980rdesgroppes wants to merge 1 commit into
tools/bazel.bat#54980rdesgroppes wants to merge 1 commit into
Conversation
### Motivation The wrapper advises Windows container users to point `XDG_CACHE_HOME` at a host directory bind-mounted through `docker run --volume`, which is reported not to work for some users: #54958 (comment) It might be host- or container- dependent because CI uses it without problem. ### What does this PR do? Remove that hint, leaving the POSIX `tools/bazel` counterpart alone as bind-mounted caches do work in Linux containers. Container detection stays, as the downstream `--output_base` override and remote-cache eligibility check still rely on it. ### Describe how you validated your changes On Windows with `DOTNET_RUNNING_IN_CONTAINER=1` and a non-existent `XDG_CACHE_HOME`, the wrapper no longer prints the hint, while the remote-cache hint and the CI guard behave exactly as before. ### Additional Notes Kept out of #54958 so it can be reverted independently.
rdesgroppes
added
the
qa/no-code-change
github-actions
Bot
added
the
short review
Contributor
Files inventory check summaryFile checks results against ancestor 2f7478b4: Results for datadog-agent_7.84.0~devel.git.232.7ef650d.pipeline.131307823-1_amd64.deb:No change detected Results for datadog-iot-agent_7.84.0~devel.git.232.7ef650d.pipeline.131307823-1_amd64.deb:No change detected |
alopezz
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The wrapper advises Windows container users to point
XDG_CACHE_HOMEat a host directory bind-mounted throughdocker run --volume, which is reported not to work for some users: #54958 (comment).It might be host- or container- dependent because CI uses it without problem.
What does this PR do?
Remove that hint, leaving the POSIX
tools/bazelcounterpart alone as bind-mounted caches do work in Linux containers.Container detection stays, as the downstream
--output_baseoverride and remote-cache eligibility check still rely on it.Describe how you validated your changes
On Windows with
DOTNET_RUNNING_IN_CONTAINER=1and a non-existentXDG_CACHE_HOME, the wrapper no longer prints the hint, while the remote-cache hint and the CI guard behave exactly as before.Additional Notes
Kept out of #54958 so it can be reverted independently.