feat(flags): add rules engine boundary (FFL-2837 PR1) - #1346
Draft
btthomas wants to merge 2 commits into
Draft
Conversation
This was referenced Jul 24, 2026
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR1
branch
from
July 27, 2026 19:53
bb7ad12 to
d8dd76f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request stack
Summary
This PR adds the internal boundary for dynamic offline rule evaluation.
FlagsClientor provider behavior.Reason
The React Native SDK must not implement a second rules engine. The adapter keeps flagging-core details out of the SDK state machine. Tests can replace the adapter with a deterministic fake.
Temporary upstream code
The latest published flagging-core version is 2.0.2. It does not contain the rules wire and protobuf evaluator from openfeature-js-client#344.
This PR has three
TODO(FFL-2837)items:The fake rules engine is a permanent unit-test boundary. It is not an upstream compatibility shim.
Rules evaluations do not recover
extraLogging. That field is deprecated and is not part of the new rules response.User impact
There is no new user-visible behavior in this PR. Existing online and precomputed offline evaluation do not change.
Checks
yarn tsc --noEmit -p packages/core/tsconfig.json