Add new integration for Servlet Filters, HttpServlet, and RequestDispatcher#1050
Merged
Conversation
tylerbenson
force-pushed
the
tyler/servlet-depth
branch
4 times, most recently
from
886da9e to
c2e2961
Compare
tylerbenson
changed the title
…atcher Disabled by default, and only creates a span if existing trace detected. To enable all of them: * System Property: `-Ddd.integration.servlet.enabled=true` * Environment Variable: `DD_INTEGRATION_SERVLET_ENABLED=true` (They have independent configs as well. If needed, view the source below.)
tylerbenson
force-pushed
the
tyler/servlet-depth
branch
from
c2e2961 to
4251561
Compare
dougqh
reviewed
Oct 28, 2019
Contributor
dougqh
left a comment
dougqh
left a comment
There was a problem hiding this comment.
I made a couple small comments, but overall, it looks fine to me.
However, I don't feel that I understand the contextStore or AgentPropagation well-enough to say for certain.
| import datadog.trace.agent.decorator.BaseDecorator; | ||
|
|
||
| public class HttpServletResponseDecorator extends BaseDecorator { | ||
| public static final HttpServletResponseDecorator DECORATE = new HttpServletResponseDecorator(); |
Contributor
Author
There was a problem hiding this comment.
This is primarily an optimization to avoid creating numerous objects. That it's a singleton is just a side-effect.
dougqh
approved these changes
Oct 28, 2019
Contributor
dougqh
left a comment
dougqh
left a comment
There was a problem hiding this comment.
Got a bit more background in separate conversation, looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled by default, and only creates a span if existing trace detected.
To enable all of them:
-Ddd.integration.servlet.enabled=trueDD_INTEGRATION_SERVLET_ENABLED=true(They have independent configs as well. If needed, view the source below.)