Add servlet integrations for request and response dispatch back in.#1165
Merged
Conversation
…er evaluation" This reverts commit 2432a92.
…ault. Change config for Servlet Filter and Service and JDBC DataSource instrumentation so it must be explicitly enabled (won't be enabled by accident if all of servlet is enabled).
tylerbenson
commented
Jan 10, 2020
| propagate().inject(span, request, SETTER); | ||
|
|
||
| // temporarily remove from request to avoid spring resource name bubbling up: | ||
| request.removeAttribute(DD_SPAN_ATTRIBUTE); |
Contributor
Author
There was a problem hiding this comment.
This change fixed the resource naming issue with the sample hybris application.
servlet-service is off by default, so we can't rely on it being called there.
dougqh
approved these changes
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds back instrumentation that was previously reverted and enables some by default that are less likely to change the trace size significantly.
Original PR: #1050
Revert PR: #1085
I also adjusted the instrumentation for servlet forward/include to remove the span from the request so the resource name doesn't get stomped on by subsequent child calls.