Fix incorrect os_info reporting in crash tracker#10948
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomasterfrom Mar 25, 2026
Merged
Fix incorrect os_info reporting in crash tracker#10948gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomasterfrom
os_info reporting in crash tracker#10948gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~db16095c9a, baseline=1.61.0-SNAPSHOT~1097c060fa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061309
Total [baseline] (11.129 s) : 0, 11128579
Agent [candidate] (1.064 s) : 0, 1063950
Total [candidate] (11.076 s) : 0, 11076340
section appsec
Agent [baseline] (1.246 s) : 0, 1246053
Total [baseline] (11.181 s) : 0, 11180846
Agent [candidate] (1.253 s) : 0, 1252817
Total [candidate] (11.112 s) : 0, 11111980
section iast
Agent [baseline] (1.226 s) : 0, 1225622
Total [baseline] (11.327 s) : 0, 11326776
Agent [candidate] (1.226 s) : 0, 1226324
Total [candidate] (11.336 s) : 0, 11336463
section profiling
Agent [baseline] (1.185 s) : 0, 1184943
Total [baseline] (11.075 s) : 0, 11074821
Agent [candidate] (1.182 s) : 0, 1182495
Total [candidate] (11.013 s) : 0, 11012787
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~db16095c9a, baseline=1.61.0-SNAPSHOT~1097c060fa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (631.493 ms) : 0, 631493
BytebuddyAgent [candidate] (631.785 ms) : 0, 631785
AgentMeter [baseline] (29.475 ms) : 0, 29475
AgentMeter [candidate] (29.646 ms) : 0, 29646
GlobalTracer [baseline] (257.568 ms) : 0, 257568
GlobalTracer [candidate] (258.667 ms) : 0, 258667
AppSec [baseline] (31.837 ms) : 0, 31837
AppSec [candidate] (31.948 ms) : 0, 31948
Debugger [baseline] (60.606 ms) : 0, 60606
Debugger [candidate] (60.843 ms) : 0, 60843
Remote Config [baseline] (596.757 µs) : 0, 597
Remote Config [candidate] (598.677 µs) : 0, 599
Telemetry [baseline] (8.068 ms) : 0, 8068
Telemetry [candidate] (8.871 ms) : 0, 8871
Flare Poller [baseline] (4.341 ms) : 0, 4341
Flare Poller [candidate] (4.305 ms) : 0, 4305
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (657.676 ms) : 0, 657676
BytebuddyAgent [candidate] (662.002 ms) : 0, 662002
AgentMeter [baseline] (12.123 ms) : 0, 12123
AgentMeter [candidate] (12.185 ms) : 0, 12185
GlobalTracer [baseline] (257.803 ms) : 0, 257803
GlobalTracer [candidate] (258.975 ms) : 0, 258975
AppSec [baseline] (178.277 ms) : 0, 178277
AppSec [candidate] (178.488 ms) : 0, 178488
Debugger [baseline] (65.99 ms) : 0, 65990
Debugger [candidate] (66.393 ms) : 0, 66393
Remote Config [baseline] (632.856 µs) : 0, 633
Remote Config [candidate] (648.251 µs) : 0, 648
Telemetry [baseline] (8.329 ms) : 0, 8329
Telemetry [candidate] (8.44 ms) : 0, 8440
Flare Poller [baseline] (3.572 ms) : 0, 3572
Flare Poller [candidate] (3.66 ms) : 0, 3660
IAST [baseline] (24.173 ms) : 0, 24173
IAST [candidate] (24.279 ms) : 0, 24279
section iast
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (794.285 ms) : 0, 794285
BytebuddyAgent [candidate] (795.444 ms) : 0, 795444
AgentMeter [baseline] (11.408 ms) : 0, 11408
AgentMeter [candidate] (11.387 ms) : 0, 11387
GlobalTracer [baseline] (246.65 ms) : 0, 246650
GlobalTracer [candidate] (246.694 ms) : 0, 246694
AppSec [baseline] (26.408 ms) : 0, 26408
AppSec [candidate] (26.462 ms) : 0, 26462
Debugger [baseline] (71.163 ms) : 0, 71163
Debugger [candidate] (70.639 ms) : 0, 70639
Remote Config [baseline] (533.138 µs) : 0, 533
Remote Config [candidate] (531.112 µs) : 0, 531
Telemetry [baseline] (9.221 ms) : 0, 9221
Telemetry [candidate] (9.199 ms) : 0, 9199
Flare Poller [baseline] (3.356 ms) : 0, 3356
Flare Poller [candidate] (3.338 ms) : 0, 3338
IAST [baseline] (25.293 ms) : 0, 25293
IAST [candidate] (25.337 ms) : 0, 25337
section profiling
ProfilingAgent [baseline] (94.494 ms) : 0, 94494
ProfilingAgent [candidate] (93.937 ms) : 0, 93937
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (682.961 ms) : 0, 682961
BytebuddyAgent [candidate] (682.419 ms) : 0, 682419
AgentMeter [baseline] (9.032 ms) : 0, 9032
AgentMeter [candidate] (8.999 ms) : 0, 8999
GlobalTracer [baseline] (215.964 ms) : 0, 215964
GlobalTracer [candidate] (215.284 ms) : 0, 215284
AppSec [baseline] (32.375 ms) : 0, 32375
AppSec [candidate] (32.177 ms) : 0, 32177
Debugger [baseline] (66.136 ms) : 0, 66136
Debugger [candidate] (65.071 ms) : 0, 65071
Remote Config [baseline] (573.194 µs) : 0, 573
Remote Config [candidate] (560.562 µs) : 0, 561
Telemetry [baseline] (7.737 ms) : 0, 7737
Telemetry [candidate] (7.763 ms) : 0, 7763
Flare Poller [baseline] (3.51 ms) : 0, 3510
Flare Poller [candidate] (4.244 ms) : 0, 4244
Profiling [baseline] (95.062 ms) : 0, 95062
Profiling [candidate] (94.493 ms) : 0, 94493
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~db16095c9a, baseline=1.61.0-SNAPSHOT~1097c060fa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051616
Total [baseline] (8.86 s) : 0, 8860357
Agent [candidate] (1.074 s) : 0, 1073966
Total [candidate] (8.898 s) : 0, 8897977
section iast
Agent [baseline] (1.226 s) : 0, 1225956
Total [baseline] (9.536 s) : 0, 9535522
Agent [candidate] (1.239 s) : 0, 1239343
Total [candidate] (9.551 s) : 0, 9550868
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~db16095c9a, baseline=1.61.0-SNAPSHOT~1097c060fa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.232 ms) : 0, 1232
BytebuddyAgent [baseline] (626.638 ms) : 0, 626638
BytebuddyAgent [candidate] (639.248 ms) : 0, 639248
AgentMeter [baseline] (29.245 ms) : 0, 29245
AgentMeter [candidate] (30.101 ms) : 0, 30101
GlobalTracer [baseline] (255.655 ms) : 0, 255655
GlobalTracer [candidate] (261.288 ms) : 0, 261288
AppSec [baseline] (31.587 ms) : 0, 31587
AppSec [candidate] (32.156 ms) : 0, 32156
Debugger [baseline] (59.33 ms) : 0, 59330
Debugger [candidate] (60.456 ms) : 0, 60456
Remote Config [baseline] (582.759 µs) : 0, 583
Remote Config [candidate] (593.589 µs) : 0, 594
Telemetry [baseline] (7.989 ms) : 0, 7989
Telemetry [candidate] (8.905 ms) : 0, 8905
Flare Poller [baseline] (3.479 ms) : 0, 3479
Flare Poller [candidate] (3.644 ms) : 0, 3644
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (794.853 ms) : 0, 794853
BytebuddyAgent [candidate] (805.235 ms) : 0, 805235
AgentMeter [baseline] (11.382 ms) : 0, 11382
AgentMeter [candidate] (11.716 ms) : 0, 11716
GlobalTracer [baseline] (247.287 ms) : 0, 247287
GlobalTracer [candidate] (249.559 ms) : 0, 249559
AppSec [baseline] (26.549 ms) : 0, 26549
AppSec [candidate] (26.788 ms) : 0, 26788
Debugger [baseline] (67.293 ms) : 0, 67293
Debugger [candidate] (67.107 ms) : 0, 67107
Remote Config [baseline] (529.075 µs) : 0, 529
Remote Config [candidate] (523.006 µs) : 0, 523
Telemetry [baseline] (11.32 ms) : 0, 11320
Telemetry [candidate] (11.274 ms) : 0, 11274
Flare Poller [baseline] (3.984 ms) : 0, 3984
Flare Poller [candidate] (3.945 ms) : 0, 3945
IAST [baseline] (25.417 ms) : 0, 25417
IAST [candidate] (25.607 ms) : 0, 25607
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~db16095c9a, baseline=1.61.0-SNAPSHOT~1097c060fa
dateFormat X
axisFormat %s
section baseline
no_agent (17.22 ms) : 17046, 17395
. : milestone, 17220,
appsec (18.563 ms) : 18378, 18748
. : milestone, 18563,
code_origins (17.62 ms) : 17447, 17793
. : milestone, 17620,
iast (18.549 ms) : 18364, 18735
. : milestone, 18549,
profiling (18.567 ms) : 18383, 18751
. : milestone, 18567,
tracing (17.522 ms) : 17347, 17696
. : milestone, 17522,
section candidate
no_agent (17.811 ms) : 17630, 17992
. : milestone, 17811,
appsec (18.756 ms) : 18565, 18947
. : milestone, 18756,
code_origins (17.737 ms) : 17562, 17913
. : milestone, 17737,
iast (17.501 ms) : 17325, 17677
. : milestone, 17501,
profiling (20.664 ms) : 20460, 20869
. : milestone, 20664,
tracing (17.433 ms) : 17258, 17607
. : milestone, 17433,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~db16095c9a, baseline=1.61.0-SNAPSHOT~1097c060fa
dateFormat X
axisFormat %s
section baseline
no_agent (1.187 ms) : 1175, 1199
. : milestone, 1187,
iast (3.22 ms) : 3177, 3263
. : milestone, 3220,
iast_FULL (5.915 ms) : 5855, 5974
. : milestone, 5915,
iast_GLOBAL (3.793 ms) : 3725, 3861
. : milestone, 3793,
profiling (2.013 ms) : 1995, 2031
. : milestone, 2013,
tracing (1.837 ms) : 1821, 1853
. : milestone, 1837,
section candidate
no_agent (1.188 ms) : 1176, 1200
. : milestone, 1188,
iast (3.245 ms) : 3197, 3292
. : milestone, 3245,
iast_FULL (5.797 ms) : 5739, 5855
. : milestone, 5797,
iast_GLOBAL (3.452 ms) : 3400, 3504
. : milestone, 3452,
profiling (2.174 ms) : 2155, 2194
. : milestone, 2174,
tracing (1.788 ms) : 1774, 1802
. : milestone, 1788,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~db16095c9a, baseline=1.61.0-SNAPSHOT~1097c060fa
dateFormat X
axisFormat %s
section baseline
no_agent (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
appsec (14.75 s) : 14750000, 14750000
. : milestone, 14750000,
iast (18.14 s) : 18140000, 18140000
. : milestone, 18140000,
iast_GLOBAL (17.634 s) : 17634000, 17634000
. : milestone, 17634000,
profiling (15.324 s) : 15324000, 15324000
. : milestone, 15324000,
tracing (14.759 s) : 14759000, 14759000
. : milestone, 14759000,
section candidate
no_agent (15.567 s) : 15567000, 15567000
. : milestone, 15567000,
appsec (14.721 s) : 14721000, 14721000
. : milestone, 14721000,
iast (18.047 s) : 18047000, 18047000
. : milestone, 18047000,
iast_GLOBAL (17.48 s) : 17480000, 17480000
. : milestone, 17480000,
profiling (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
tracing (14.77 s) : 14770000, 14770000
. : milestone, 14770000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~db16095c9a, baseline=1.61.0-SNAPSHOT~1097c060fa
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.782 ms) : 3561, 4002
. : milestone, 3782,
iast (2.243 ms) : 2174, 2312
. : milestone, 2243,
iast_GLOBAL (2.292 ms) : 2222, 2361
. : milestone, 2292,
profiling (2.088 ms) : 2032, 2144
. : milestone, 2088,
tracing (2.07 ms) : 2015, 2124
. : milestone, 2070,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.721 ms) : 3505, 3937
. : milestone, 3721,
iast (2.242 ms) : 2174, 2311
. : milestone, 2242,
iast_GLOBAL (2.288 ms) : 2219, 2358
. : milestone, 2288,
profiling (2.069 ms) : 2014, 2124
. : milestone, 2069,
tracing (2.057 ms) : 2003, 2110
. : milestone, 2057,
|
e002797 to
7c3388d
Compare
da6b90f to
db16095
Compare
os_info reporting in crash tracker
jbachorik
approved these changes
Mar 25, 2026
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This pull request resolves an issue with the
os_infovalues where incorrect data was being reported. The values are now aligned with the specifications outlined in the relevant RFC.Motivation
Ensures that
os_infodata is accurate and conforms to the expected format, improving the reliability of error reporting.Additional Notes
Refer to the RFC for additional implementation details: https://github.com/DataDog/libdatadog/blob/main/docs/RFCs/0013-crashtracker-errors-intake-payload.md
Also, fixed some gotchas with reports from JDK 8 that didn't had the time iin the summary section.