Support J9 / OpenJ9 ucontext (registers)#10959
Support J9 / OpenJ9 ucontext (registers)#10959gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
27a80b6 to
eb08fb0
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~cb8bceac58, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054103
Total [baseline] (11.054 s) : 0, 11054316
Agent [candidate] (1.057 s) : 0, 1057377
Total [candidate] (11.051 s) : 0, 11050769
section appsec
Agent [baseline] (1.257 s) : 0, 1256846
Total [baseline] (11.196 s) : 0, 11196491
Agent [candidate] (1.248 s) : 0, 1248199
Total [candidate] (11.139 s) : 0, 11138591
section iast
Agent [baseline] (1.228 s) : 0, 1227880
Total [baseline] (11.327 s) : 0, 11327187
Agent [candidate] (1.235 s) : 0, 1235345
Total [candidate] (11.343 s) : 0, 11343271
section profiling
Agent [baseline] (1.182 s) : 0, 1181916
Total [baseline] (10.982 s) : 0, 10981940
Agent [candidate] (1.182 s) : 0, 1182198
Total [candidate] (10.977 s) : 0, 10976723
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~cb8bceac58, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (626.606 ms) : 0, 626606
BytebuddyAgent [candidate] (627.854 ms) : 0, 627854
AgentMeter [baseline] (29.369 ms) : 0, 29369
AgentMeter [candidate] (29.437 ms) : 0, 29437
GlobalTracer [baseline] (256.212 ms) : 0, 256212
GlobalTracer [candidate] (256.632 ms) : 0, 256632
AppSec [baseline] (31.717 ms) : 0, 31717
AppSec [candidate] (31.591 ms) : 0, 31591
Debugger [baseline] (60.062 ms) : 0, 60062
Debugger [candidate] (60.156 ms) : 0, 60156
Remote Config [baseline] (582.003 µs) : 0, 582
Remote Config [candidate] (592.447 µs) : 0, 592
Telemetry [baseline] (8.792 ms) : 0, 8792
Telemetry [candidate] (9.586 ms) : 0, 9586
Flare Poller [baseline] (3.518 ms) : 0, 3518
Flare Poller [candidate] (4.263 ms) : 0, 4263
section appsec
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (663.551 ms) : 0, 663551
BytebuddyAgent [candidate] (659.219 ms) : 0, 659219
AgentMeter [baseline] (12.207 ms) : 0, 12207
AgentMeter [candidate] (12.157 ms) : 0, 12157
GlobalTracer [baseline] (260.071 ms) : 0, 260071
GlobalTracer [candidate] (257.965 ms) : 0, 257965
IAST [baseline] (24.45 ms) : 0, 24450
IAST [candidate] (24.182 ms) : 0, 24182
AppSec [baseline] (179.056 ms) : 0, 179056
AppSec [candidate] (178.404 ms) : 0, 178404
Debugger [baseline] (67.021 ms) : 0, 67021
Debugger [candidate] (66.105 ms) : 0, 66105
Remote Config [baseline] (623.894 µs) : 0, 624
Remote Config [candidate] (636.146 µs) : 0, 636
Telemetry [baseline] (8.501 ms) : 0, 8501
Telemetry [candidate] (8.463 ms) : 0, 8463
Flare Poller [baseline] (3.632 ms) : 0, 3632
Flare Poller [candidate] (3.62 ms) : 0, 3620
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (796.494 ms) : 0, 796494
BytebuddyAgent [candidate] (801.506 ms) : 0, 801506
AgentMeter [baseline] (11.403 ms) : 0, 11403
AgentMeter [candidate] (11.661 ms) : 0, 11661
GlobalTracer [baseline] (247.501 ms) : 0, 247501
GlobalTracer [candidate] (248.251 ms) : 0, 248251
IAST [baseline] (25.307 ms) : 0, 25307
IAST [candidate] (25.528 ms) : 0, 25528
AppSec [baseline] (26.472 ms) : 0, 26472
AppSec [candidate] (26.719 ms) : 0, 26719
Debugger [baseline] (69.041 ms) : 0, 69041
Debugger [candidate] (70.355 ms) : 0, 70355
Remote Config [baseline] (528.656 µs) : 0, 529
Remote Config [candidate] (528.524 µs) : 0, 529
Telemetry [baseline] (10.204 ms) : 0, 10204
Telemetry [candidate] (9.782 ms) : 0, 9782
Flare Poller [baseline] (3.639 ms) : 0, 3639
Flare Poller [candidate] (3.53 ms) : 0, 3530
section profiling
crashtracking [baseline] (1.167 ms) : 0, 1167
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (682.428 ms) : 0, 682428
BytebuddyAgent [candidate] (683.008 ms) : 0, 683008
AgentMeter [baseline] (9.021 ms) : 0, 9021
AgentMeter [candidate] (9.025 ms) : 0, 9025
GlobalTracer [baseline] (214.833 ms) : 0, 214833
GlobalTracer [candidate] (214.902 ms) : 0, 214902
AppSec [baseline] (32.15 ms) : 0, 32150
AppSec [candidate] (32.147 ms) : 0, 32147
Debugger [baseline] (65.91 ms) : 0, 65910
Debugger [candidate] (65.084 ms) : 0, 65084
Remote Config [baseline] (553.435 µs) : 0, 553
Remote Config [candidate] (559.619 µs) : 0, 560
Telemetry [baseline] (7.68 ms) : 0, 7680
Telemetry [candidate] (7.621 ms) : 0, 7621
Flare Poller [baseline] (3.442 ms) : 0, 3442
Flare Poller [candidate] (4.128 ms) : 0, 4128
ProfilingAgent [baseline] (93.858 ms) : 0, 93858
ProfilingAgent [candidate] (93.661 ms) : 0, 93661
Profiling [baseline] (94.413 ms) : 0, 94413
Profiling [candidate] (94.221 ms) : 0, 94221
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~cb8bceac58, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058047
Total [baseline] (8.881 s) : 0, 8880943
Agent [candidate] (1.067 s) : 0, 1067228
Total [candidate] (8.862 s) : 0, 8862274
section iast
Agent [baseline] (1.226 s) : 0, 1226391
Total [baseline] (9.54 s) : 0, 9540459
Agent [candidate] (1.225 s) : 0, 1225338
Total [candidate] (9.566 s) : 0, 9566188
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~cb8bceac58, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (629.458 ms) : 0, 629458
BytebuddyAgent [candidate] (634.957 ms) : 0, 634957
AgentMeter [baseline] (29.548 ms) : 0, 29548
AgentMeter [candidate] (29.955 ms) : 0, 29955
GlobalTracer [baseline] (256.741 ms) : 0, 256741
GlobalTracer [candidate] (259.56 ms) : 0, 259560
AppSec [baseline] (31.714 ms) : 0, 31714
AppSec [candidate] (32.133 ms) : 0, 32133
Debugger [baseline] (59.593 ms) : 0, 59593
Debugger [candidate] (60.239 ms) : 0, 60239
Remote Config [baseline] (590.758 µs) : 0, 591
Remote Config [candidate] (591.712 µs) : 0, 592
Telemetry [baseline] (8.028 ms) : 0, 8028
Telemetry [candidate] (8.075 ms) : 0, 8075
Flare Poller [baseline] (5.006 ms) : 0, 5006
Flare Poller [candidate] (4.218 ms) : 0, 4218
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (795.397 ms) : 0, 795397
BytebuddyAgent [candidate] (795.201 ms) : 0, 795201
AgentMeter [baseline] (11.354 ms) : 0, 11354
AgentMeter [candidate] (11.393 ms) : 0, 11393
GlobalTracer [baseline] (247.346 ms) : 0, 247346
GlobalTracer [candidate] (246.952 ms) : 0, 246952
IAST [baseline] (25.361 ms) : 0, 25361
IAST [candidate] (25.342 ms) : 0, 25342
AppSec [baseline] (26.54 ms) : 0, 26540
AppSec [candidate] (27.305 ms) : 0, 27305
Debugger [baseline] (66.808 ms) : 0, 66808
Debugger [candidate] (68.225 ms) : 0, 68225
Remote Config [baseline] (525.995 µs) : 0, 526
Remote Config [candidate] (526.551 µs) : 0, 527
Telemetry [baseline] (11.72 ms) : 0, 11720
Telemetry [candidate] (9.646 ms) : 0, 9646
Flare Poller [baseline] (4.094 ms) : 0, 4094
Flare Poller [candidate] (3.459 ms) : 0, 3459
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~cb8bceac58, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (1.205 ms) : 1193, 1217
. : milestone, 1205,
iast (3.13 ms) : 3090, 3171
. : milestone, 3130,
iast_FULL (5.776 ms) : 5719, 5834
. : milestone, 5776,
iast_GLOBAL (3.573 ms) : 3518, 3629
. : milestone, 3573,
profiling (2.071 ms) : 2051, 2092
. : milestone, 2071,
tracing (1.783 ms) : 1769, 1797
. : milestone, 1783,
section candidate
no_agent (1.219 ms) : 1206, 1232
. : milestone, 1219,
iast (3.157 ms) : 3113, 3202
. : milestone, 3157,
iast_FULL (6.02 ms) : 5957, 6082
. : milestone, 6020,
iast_GLOBAL (3.651 ms) : 3587, 3715
. : milestone, 3651,
profiling (2.128 ms) : 2109, 2146
. : milestone, 2128,
tracing (1.772 ms) : 1757, 1786
. : milestone, 1772,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~cb8bceac58, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (19.107 ms) : 18907, 19308
. : milestone, 19107,
appsec (18.524 ms) : 18336, 18712
. : milestone, 18524,
code_origins (17.754 ms) : 17576, 17932
. : milestone, 17754,
iast (17.591 ms) : 17418, 17764
. : milestone, 17591,
profiling (19.282 ms) : 19089, 19474
. : milestone, 19282,
tracing (17.831 ms) : 17659, 18003
. : milestone, 17831,
section candidate
no_agent (18.921 ms) : 18728, 19114
. : milestone, 18921,
appsec (18.348 ms) : 18163, 18532
. : milestone, 18348,
code_origins (17.659 ms) : 17485, 17834
. : milestone, 17659,
iast (17.816 ms) : 17640, 17993
. : milestone, 17816,
profiling (19.606 ms) : 19405, 19807
. : milestone, 19606,
tracing (17.763 ms) : 17588, 17939
. : milestone, 17763,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~cb8bceac58, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (15.422 s) : 15422000, 15422000
. : milestone, 15422000,
appsec (14.7 s) : 14700000, 14700000
. : milestone, 14700000,
iast (17.925 s) : 17925000, 17925000
. : milestone, 17925000,
iast_GLOBAL (18.037 s) : 18037000, 18037000
. : milestone, 18037000,
profiling (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
tracing (15.227 s) : 15227000, 15227000
. : milestone, 15227000,
section candidate
no_agent (15.453 s) : 15453000, 15453000
. : milestone, 15453000,
appsec (14.873 s) : 14873000, 14873000
. : milestone, 14873000,
iast (18.43 s) : 18430000, 18430000
. : milestone, 18430000,
iast_GLOBAL (17.984 s) : 17984000, 17984000
. : milestone, 17984000,
profiling (15.178 s) : 15178000, 15178000
. : milestone, 15178000,
tracing (14.777 s) : 14777000, 14777000
. : milestone, 14777000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~cb8bceac58, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1490
. : milestone, 1478,
appsec (3.752 ms) : 3535, 3968
. : milestone, 3752,
iast (2.28 ms) : 2210, 2350
. : milestone, 2280,
iast_GLOBAL (2.311 ms) : 2242, 2381
. : milestone, 2311,
profiling (2.129 ms) : 2072, 2186
. : milestone, 2129,
tracing (2.085 ms) : 2031, 2139
. : milestone, 2085,
section candidate
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.849 ms) : 3627, 4071
. : milestone, 3849,
iast (2.258 ms) : 2189, 2327
. : milestone, 2258,
iast_GLOBAL (2.306 ms) : 2237, 2376
. : milestone, 2306,
profiling (2.488 ms) : 2333, 2643
. : milestone, 2488,
tracing (2.075 ms) : 2021, 2128
. : milestone, 2075,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This merge request conflicts with another merge request ahead in the queue. The merge requests in front of this one are: |
Parse the GPINFO register section (1XHREGISTERS / 2XHREGISTER tags)
from J9/OpenJ9 javacore crash dumps mirroring what was done for HotSpot.
Register format:
1XHREGISTERS Registers:
2XHREGISTER RIP: 00007F8B7C0B3D7D (x86-64)
2XHREGISTER PC: 0000FFFF98B9FB6C (aarch64)
Added crash dumps from IBM J9 (Java 8) and IBM Semeru / OpenJ9 (Java 11)
that were obtained using Docker and this crashing program:
```java
import sun.misc.Unsafe;
import java.lang.reflect.Field;
public class Crash {
public static void main(String[] args) throws Exception {
Field f = Unsafe.class.getDeclaredField("theUnsafe");
f.setAccessible(true);
Unsafe unsafe = (Unsafe) f.get(null);
unsafe.putInt(0L, 42); // SIGSEGV -> GPF dump
}
}
```
```
docker run --rm -v /tmp/j9-crash-test:/work ibmjava:8-sdk \
bash -c "cd /work && javac Crash.java && \
java -Xdump:java:events=gpf,file=/work/javacore.ibmj9.txt Crash"
```
```
docker run --rm -v /tmp/j9-crash-test:/work ibm-semeru-runtimes:open-11-jdk \
bash -c "cd /work && javac Crash.java && \
java -Xdump:java:events=gpf,file=/work/javacore.openj9.txt Crash"
```
eb08fb0 to
cb8bcea
Compare
|
/merge -c |
|
View all feedbacks in Devflow UI.
This merge request is not in the queue and can't be unqueued To get help about command usage, write If you need support, contact us on Slack #devflow with those details! |
|
/merge --help |
|
View all feedbacks in Devflow UI.
Add the current pull request in a queue to be processed and merged
Examples:
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
|
/merge --help |
|
View all feedbacks in Devflow UI.
Add the current pull request in a queue to be processed and merged
Examples:
|
What Does This Do
This PR parses the GPINFO register section (
1XHREGISTERS/2XHREGISTERtags) from J9/OpenJ9 javacore crash dumps mirroring what was done for HotSpot inThe J9/OpenJ9 register format is :
Additional Notes
There was a crashdump but it didn't had any registers, so I generated new ones for IBM J9 (Java 8) and IBM Semeru / OpenJ9 (Java 11) that were obtained using Docker and this crashing program:
Note the default J9 javacore dump agent fires on multiple events (gpf, user, vmstop, etc.). By specifying
events=gpfwe restricted it to only fire on the crash signal.Also,
gpfstands for General Protection Fault — it is the J9/OpenJ9 name for a segmentation fault (SIGSEGV). And it's mentioned mentioned it in the javacore header:Doc: https://eclipse.dev/openj9/docs/xdump/#dump-events