Migrate dd-trace-core groovy files to java part 6#11362
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intoMay 15, 2026
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
we migrate 6 tests - PendingTracerBufferTest - PendingTraceStrictWriteTest - PendingTraceTest - PendingTraceTestBase - TraceInterceptorTest - TracingConfigPollerTest
jpbempel
force-pushed
the
jpbempel/g2j-core-pt6
branch
from
abcd3c1 to
66b5f3c
Compare
jpbempel
added
comp: testing
dougqh
reviewed
May 13, 2026
| return "0"; | ||
| } | ||
|
|
||
| // @VisibleForTesting |
Contributor
There was a problem hiding this comment.
I'd be fine with package visible member variables, but I don't feel strongly either way.
dougqh
approved these changes
May 13, 2026
bric3
reviewed
May 13, 2026
bric3
reviewed
May 14, 2026
Contributor
bric3
left a comment
bric3
left a comment
There was a problem hiding this comment.
I found a few issues in the port on PendingTraceBufferTest, that's strange that the llm didn't caught them
jpbempel
force-pushed
the
jpbempel/g2j-core-pt6
branch
from
2bc0b33 to
04c28fc
Compare
bric3
approved these changes
May 15, 2026
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
gh-worker-dd-mergequeue-cf854d
Bot
merged commit 86eece6
into
master
735 of 758 checks passed
kaahos
pushed a commit
that referenced
this pull request
May 15, 2026
Migrate dd-trace-core groovy files to java part 6 we migrate 6 tests - PendingTracerBufferTest - PendingTraceStrictWriteTest - PendingTraceTest - PendingTraceTestBase - TraceInterceptorTest - TracingConfigPollerTest address comments Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
we migrate 6 tests
Motivation
this is part of the effort to migrate groovy tests to Java/JUnit
part1: #11053
part2: #11062
part3: #11085
part4: #11146
part5: #11217
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.