Mark PendingTraceBufferTest tests flaky#11383
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoMay 15, 2026
Merged
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
sarahchen6
added
tag: no release notes
mhlidd
approved these changes
May 15, 2026
AlexeyKuznetsov-DD
approved these changes
May 15, 2026
Contributor
Author
|
/merge -f --reason "mark tests as flaky" |
|
View all feedbacks in Devflow UI.
The expected merge time in
Warning This change was merged without running any pre merge CI checks Reason: mark tests as flaky |
gh-worker-dd-mergequeue-cf854d
Bot
merged commit ed7e5f3
into
master
581 of 585 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Mark PendingTraceBufferTest tests flaky. Specifically:
bufferFullYieldsImmediateWrite()longRunningTraceBufferFullDoesNotTriggerWrite()samePendingTraceIsNotEnqueuedMultipleTimes()Motivation
After #11362, these tests have been flaky and hurting
masterCI. See this dashboard for reference.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.