Skip to content

Avoid repeated evaluation of isDbmInjectSqlBaseHash#11459

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/cache-setting-dbm
May 26, 2026
Merged

Avoid repeated evaluation of isDbmInjectSqlBaseHash#11459
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/cache-setting-dbm

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

Avoids evaluating each time DBM_PROPAGATION_MODE_DYNAMIC_SERVICE.equals(dbmPropagationMode) to know whenever inject the base hash in the dbm comment since the configuration is immutable and can evaluated once

Motivation

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@amarziali
amarziali requested a review from a team as a code owner May 26, 2026 14:49
@amarziali amarziali added the type: feature Enhancements and improvements label May 26, 2026
@amarziali amarziali added the tag: no release notes Changes to exclude from release notes label May 26, 2026
@amarziali
amarziali enabled auto-merge May 26, 2026 14:53
@datadog-official

This comment has been minimized.

@manuel-alvarez-alvarez manuel-alvarez-alvarez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali amarziali added the comp: database Database Monitoring label May 26, 2026
@amarziali
amarziali added this pull request to the merge queue May 26, 2026
@dd-octo-sts

dd-octo-sts Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented May 26, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-05-26 15:55:55 UTC ℹ️ Start processing command /merge


2026-05-26 15:55:59 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-05-26 17:06:54 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 26, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit cfb9996 into master May 26, 2026
576 of 579 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/cache-setting-dbm branch May 26, 2026 17:06
@github-actions github-actions Bot added this to the 1.63.0 milestone May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: database Database Monitoring tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants