Resolve latest patches per major Gradle version in CI workflow#11635
Conversation
This comment has been minimized.
This comment has been minimized.
daniel-mohedano
added
type: feature
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
daniel-mohedano
added
the
tag: ai generated
bric3
left a comment
bric3
left a comment
There was a problem hiding this comment.
I believe this is god to go. Thanks for the improvement!
|
|
||
| protected static final String LATEST_GRADLE_VERSION = getLatestGradleVersion(); | ||
| private static final Properties TOOL_VERSIONS = loadToolVersions(); | ||
| protected static final String LATEST_GRADLE_VERSION = toolVersion("gradle.version"); |
There was a problem hiding this comment.
suggestion: Maybe rename the property to gradle.latest so it remain consistent with the new properties ?
There was a problem hiding this comment.
good point! addressed in c96a08c + updated the maven properties also to follow the same structure
| // - "oldest": the latest patch of the oldest major the current Gradle TestKit still supports | ||
| // Any other value is treated as a concrete version and returned as-is. | ||
| private static String resolveVersion(String gradleVersion) { | ||
| if ("latest".equals(gradleVersion)) { |
There was a problem hiding this comment.
note: FYI I didn't see any test using the "latest" marker.
There was a problem hiding this comment.
for the testLegacy scenarios all are either pinned or using oldest, but in the testNew scenarios almost all of them use latest as the Gradle version
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
2 participants
What Does This Do
Update smoke test latest versionsworkflow now also resolves the latest patches available per major release of Gradlelatest-tool-versions.properties, is used by Gradle smoke tests to determine the oldest Gradle version that the project's TestKit supports and can be tested.Motivation
Avoids the need of manually updating the
oldestscenario every time the project's Gradle version is bumped to a new major release.Additional Notes
test-environment-trigger: skip
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]