Fix a couple of IAST modules to use the IGSpanInfo in the event over the active span#11934
Conversation
PerfectSlayer
left a comment
There was a problem hiding this comment.
Thanks for the follow up changes
There was a problem hiding this comment.
More details
The cast (AgentSpan) igSpanInfo is safe for all production inputs: AgentSpan extends IGSpanInfo and no class in this codebase implements IGSpanInfo without also implementing AgentSpan (verified by exhaustive grep). Null is handled correctly — an NPE from igSpanInfo.getTags() on line 39 (before the cast on line 51) is swallowed by the existing catch (Throwable e) block, so the 'exception not thrown if igSpanInfo is null' test continues to pass. No behavioral regressions found.
📊 Validated against 5 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 9965175 · What is Autotest? · Any feedback? Reach out in #autotest
|
🎯 Code Coverage (details) 🔗 Commit SHA: 9965175 | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 7085489522989408789 took longer than expected. The current limit for the base branch 'master' is 120 minutes. Possible reasons:
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
fbb45e7
into
master
Motivation
Avoids use of
activeSpanwhen the span is already available in the gateway event.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]