Skip to content

Fix NullPointerException in Exception Replay#11976

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
jpbempel/fix-npe-er
Jul 22, 2026
Merged

Fix NullPointerException in Exception Replay#11976
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
jpbempel/fix-npe-er

Conversation

@jpbempel

@jpbempel jpbempel commented Jul 16, 2026

Copy link
Copy Markdown
Member

What Does This Do

fingerprint can be null in rare occasions

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-5675

fingerprint can be null in rare occasions
@jpbempel
jpbempel requested a review from a team as a code owner July 16, 2026 16:46
@jpbempel
jpbempel requested review from ojung and removed request for a team July 16, 2026 16:46
@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: bug fix Bug fix labels Jul 16, 2026

@datadog-prod-us1-3 datadog-prod-us1-3 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

Null fingerprint check correctly handles a rare but real edge case in exception replay where circular exception chains or digest algorithm failures cause Fingerprinter.fingerprint() to return null. The fix is minimal, focused, and prevents a NullPointerException without changing behavior for normal exceptions. Existing tests (FingerprinterTest.innerInfiniteLoop) confirm this code path is reachable.

Was this helpful? React 👍 or 👎

📊 Validated against 4 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 1910776 · What is Autotest? · Any feedback? Reach out in #autotest

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 16, 2026

Copy link
Copy Markdown

View session in Datadog

Bits Code status: ✅ Done

Comment @DataDog to request changes

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 16, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 0.00%
Overall Coverage: 74.45% (+17.27%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1910776 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.89 s 13.91 s [-0.9%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.88 s 12.91 s [-0.8%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 16.73 s 16.70 s [-0.9%; +1.3%] (no difference)
startup:petclinic:iast:Agent 16.84 s 16.99 s [-1.6%; -0.2%] (maybe better)
startup:petclinic:profiling:Agent 16.69 s 16.86 s [-2.3%; +0.3%] (no difference)
startup:petclinic:sca:Agent 16.92 s 16.05 s [+1.2%; +9.7%] (significantly worse)
startup:petclinic:tracing:Agent 16.02 s 16.22 s [-1.9%; -0.6%] (maybe better)

Commit: 19107763 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@jpbempel
jpbempel added this pull request to the merge queue Jul 22, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 22, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-22 05:15:38 UTC ℹ️ Start processing command /merge


2026-07-22 05:15:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-07-22 06:14:56 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 45a9d0e into master Jul 22, 2026
789 of 799 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the jpbempel/fix-npe-er branch July 22, 2026 06:14
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: debugger Dynamic Instrumentation type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants