Add `Locale.ROOT` to ConfigStrings Environment Variable Normalization by mhlidd · Pull Request #11979 · DataDog/dd-trace-java

mhlidd · 2026-07-16T20:31:50Z

What Does This Do

Previously, Turkish Locale would uppercase i -> a dotted I. This led to issues w/ our telemetry monitors after hitting the backend, sparking false alarms that were were not properly capturing config telemetry.

This PR also replaces a duplicate function systemPropertyNameToEnvironmentVariableName to toEnvVar.

Motivation

Additional Notes

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Once approved, use merge queue to merge the PR

Jira ticket: [PROJ-IDENT]

dd-octo-sts · 2026-07-16T20:32:02Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

datadog-datadog-prod-us1

More details

The PR correctly fixes a locale-sensitive bug where Turkish systems would corrupt config telemetry by converting 'i' → 'İ' (dotted I) instead of 'I'. Adding Locale.ROOT to toUpperCase() and toLowerCase() ensures all environment variable name conversions use ASCII-invariant transformations. The deprecated systemPropertyNameToEnvironmentVariableName() is safely removed and replaced with the fixed toEnvVar() at its only call site. The new test forces Turkish locale and verifies the fix prevents the corruption.

Was this helpful? React 👍 or 👎

_{📊 Validated against 6 scenarios · Open Bits AI session}

_{🤖 Datadog Autotest · Commit f326662 · What is Autotest? · Any feedback? Reach out in #autotest}

bm1549

LGTM since it solves the issue at hand, but I do wonder how many of the remaining toUpperCase / toLowerCase instances may be causing similar problems we just haven't found yet

https://github.com/search?q=repo%3ADataDog%2Fdd-trace-java+Case%28%29&type=code

datadog-datadog-prod-us1 · 2026-07-16T20:47:10Z

🎯 Code Coverage (details)
• Patch Coverage: 50.00%
• Overall Coverage: 57.26% (-0.04%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: d2e62e8 | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-07-16T20:56:16Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.94 s	13.90 s	[-0.4%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent	12.91 s	13.02 s	[-1.6%; -0.0%] (maybe better)
startup:petclinic:appsec:Agent	16.95 s	16.75 s	[+0.2%; +2.3%] (maybe worse)
startup:petclinic:iast:Agent	16.39 s	16.97 s	[-7.7%; +0.9%] (no difference)
startup:petclinic:profiling:Agent	16.64 s	16.83 s	[-2.3%; +0.1%] (no difference)
startup:petclinic:sca:Agent	16.92 s	16.77 s	[-0.2%; +1.9%] (no difference)
startup:petclinic:tracing:Agent	16.12 s	16.09 s	[-0.7%; +1.1%] (no difference)

Commit: d2e62e8c · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

PerfectSlayer · 2026-07-17T07:30:18Z

+  @BeforeEach
+  void forceTurkishLocale() {


❔ question: ‏Not sure it makes sense to force the Turkish locale for all tests (the current one and all comings next)
What about limiting it to the related test case instead?

Good Catch, I'll just add it to the test case itself

fixed in d2e62e8

dd-octo-sts · 2026-07-17T17:48:35Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-07-17T17:48:40Z

View all feedbacks in Devflow UI.

2026-07-17 17:48:39 UTC ℹ️ Start processing command /merge

2026-07-17 17:48:45 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).

2026-07-17 18:13:20 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 92d254c:

jetty-app.amd64.DOC: [public.ecr.aws/docker/library/oraclelinux:9, linux/amd64, 17.0.15-zulu]

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

dd-octo-sts · 2026-07-17T18:50:27Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-07-17T18:50:32Z

View all feedbacks in Devflow UI.

2026-07-17 18:50:31 UTC ℹ️ Start processing command /merge

2026-07-17 18:50:37 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).

2026-07-17 19:55:44 UTC ℹ️ MergeQueue: This merge request was merged

adding locale.root to toEnvVar

f326662

mhlidd requested a review from a team as a code owner July 16, 2026 20:31

mhlidd requested a review from manuel-alvarez-alvarez July 16, 2026 20:31

mhlidd requested review from PerfectSlayer and bm1549 July 16, 2026 20:32

mhlidd added type: bug fix Bug fix comp: config Configuration labels Jul 16, 2026

datadog-datadog-prod-us1 Bot reviewed Jul 16, 2026

View reviewed changes

bm1549 approved these changes Jul 16, 2026

View reviewed changes

PerfectSlayer reviewed Jul 17, 2026

View reviewed changes

force locale for individual test

d2e62e8

mhlidd added this pull request to the merge queue Jul 17, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 17, 2026

mhlidd added this pull request to the merge queue Jul 17, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 17, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit e41dc82 into master Jul 17, 2026
781 of 783 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the mhlidd/add_locale_to_config_strings branch July 17, 2026 19:55

github-actions Bot added this to the 1.65.0 milestone Jul 17, 2026

Uh oh!

Conversation

mhlidd commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

dd-octo-sts Bot commented Jul 16, 2026

Uh oh!

datadog-datadog-prod-us1 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

bm1549 left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1 Bot commented Jul 16, 2026 • edited by datadog-prod-us1-5 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

PerfectSlayer Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

mhlidd Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

mhlidd Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

dd-octo-sts Bot commented Jul 17, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

Uh oh!

dd-octo-sts Bot commented Jul 17, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mhlidd commented Jul 16, 2026 •

edited

Loading

datadog-datadog-prod-us1 Bot commented Jul 16, 2026 •

edited by datadog-prod-us1-5 Bot

Loading

dd-octo-sts Bot commented Jul 16, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026 •

edited

Loading