Fix race condition with reliability env deploy#12061
Conversation
There was a problem hiding this comment.
More details
The reliability deployment override correctly changes the injected job from an empty dependency set to waiting for the build, while preserving the external trigger configuration. Merge-request, scheduled, release-tag, and configuration-merge scenarios all behaved as intended; no additional tests are recommended because this non-runtime YAML change is fully covered by the dependency-graph validation.
📊 Validated against 4 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 4bed6f0 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
fc47338
into
master
What Does This Do
There's a race condition with the reliability env deploy introduced with one-pipeline 1.1.0 .
deploy_to_reliability_envhasneeds: []which means it no longer waits for previous stages to finish. Fordd-trace-java, this means the deploy job runs before thebuildjob is finished causing a failure.This PR adds
needs: [ build ]to have the trigger wait for the build to finish