Skip to content

Fix race condition with reliability env deploy#12061

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
landerson/reliability-env-needs
Jul 24, 2026
Merged

Fix race condition with reliability env deploy#12061
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
landerson/reliability-env-needs

Conversation

@randomanderson

Copy link
Copy Markdown
Contributor

What Does This Do

There's a race condition with the reliability env deploy introduced with one-pipeline 1.1.0 . deploy_to_reliability_env has needs: [] which means it no longer waits for previous stages to finish. For dd-trace-java, this means the deploy job runs before the build job is finished causing a failure.

This PR adds needs: [ build ] to have the trigger wait for the build to finish

@randomanderson
randomanderson requested review from a team as code owners July 23, 2026 22:16
@randomanderson
randomanderson requested review from erikayasuda and removed request for a team July 23, 2026 22:16
@randomanderson randomanderson added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 23, 2026

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The reliability deployment override correctly changes the injected job from an empty dependency set to waiting for the build, while preserving the external trigger configuration. Merge-request, scheduled, release-tag, and configuration-merge scenarios all behaved as intended; no additional tests are recommended because this non-runtime YAML change is fully covered by the dependency-graph validation.

Was this helpful? React 👍 or 👎

📊 Validated against 4 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 4bed6f0 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-datadog-prod-us1

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.77 s 14.63 s [+0.1%; +1.7%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.63 s 13.76 s [-1.7%; -0.1%] (maybe better)
startup:petclinic:appsec:Agent 16.43 s 16.68 s [-5.9%; +2.8%] (no difference)
startup:petclinic:iast:Agent 16.72 s 16.83 s [-1.4%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 16.44 s 16.60 s [-2.0%; +0.1%] (no difference)
startup:petclinic:sca:Agent 16.86 s 16.76 s [-0.3%; +1.6%] (no difference)
startup:petclinic:tracing:Agent 15.97 s 15.67 s [-2.5%; +6.3%] (no difference)

Commit: 4bed6f06 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@randomanderson

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 23, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-23 23:58:28 UTC ℹ️ Start processing command /merge


2026-07-23 23:58:32 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-07-24 00:54:44 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit fc47338 into master Jul 24, 2026
782 of 787 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the landerson/reliability-env-needs branch July 24, 2026 00:54
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants