Avoid null collection on decoded spans - #12087
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74c157ccdf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
More details
The decoder changes consistently replace absent meta_struct values with immutable empty maps across v0.4, v0.5, and v1, matching the updated smoke-test assertions. No diff-only behavioral regression was identified; local execution was attempted but the sandbox lacks the required Gradle distribution and Java 25 toolchain.
🤖 Datadog Autotest · Commit 74c157c · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
🎯 Code Coverage (details) 🔗 Commit SHA: d1a2872 | Docs | Datadog PR Page | Give us feedback! |
74c157c to
d1a2872
Compare
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
This PR updates the decoded spans to avoid null collections.
Motivation
This changes will help asserting the trace / span structure and values with the upcoming rules and matchers.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-1247