Skip to content

Remove check for JAVA_TOOLS_OPTIONS in verifyAgentJarIntegrations #12103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Jul 29, 2026
+4 −0
Merged

Remove check for JAVA_TOOLS_OPTIONS in verifyAgentJarIntegrations #12103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dd-java-agent/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,10 @@ tasks.register('verifyAgentJarIntegrations', JavaExec) {
classpath = objects.fileCollection().from(jarProvider)
args = ['--list-integrations']

// Listing integrations only inspects classes and metadata in the assembled agent jar, so it does
// not need inherited JAVA_TOOL_OPTIONS.
environment.remove('JAVA_TOOL_OPTIONS')
Comment on lines +625 to +627

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Jul 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can follow this way as a fix (and maybe even keep it).
As alternative solution we may probably need to make check logic more robust.
like add some sort of begin marker and end marker and analyze output between markers.

I just executed locally:
java -jar dd-java-agent/build/libs/dd-java-agent-1.65.0-SNAPSHOT.jar --list-integrations
and got the output:

IastInstrumentation
aerospike
akka-http
....
zio.experimental

So as possible improvements we can generate something like:
java -jar dd-java-agent/build/libs/dd-java-agent-1.65.0-SNAPSHOT.jar --list-integrations --with-marker

List of dd-trace-java integrations:
==============
IastInstrumentation
aerospike
akka-http
....
zio.experimental
===============

This is just my idea and this solution will require more work.

@bric3 bric3 Jul 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexeyKuznetsov-DD I'm not sure it's worth introducing this option in the tracer. I.e. I don't see how it would benefit other usages.

@mhdatie mhdatie Jul 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Does this remove the ENV from this Gradle task only? Meaning this would not affect other tasks running as part of the same build which may require JAVA_TOOL_OPTIONS?

@sarahchen6 sarahchen6 Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - JAVA_TOOLS_OPTIONS is removed only from the child JVM of the verifyAgentJarIntegrations Gradle task!

@bric3 bric3 Jul 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: There are another special env var JDK_JAVA_OPTIONS that offer a similar feature (albeit with some restrictions). (Ignoring the undocumented, internal hotspot specific _JAVA_OPTIONS).

That said, I'm not sure this is worth a follow-up at this time.


// Capture both stdout and stderr: InstrumenterIndex.buildModule() logs ERROR and returns null when a module
// fails to load, while the process exits with status 0.
def capturedOutput = new ByteArrayOutputStream()
Expand Down
Loading