Move advice crawl and helper resolution to separate resolver - #12191
Move advice crawl and helper resolution to separate resolver#12191sarahchen6 wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
98fc668 to
1e102d2
Compare
1e102d2 to
028cada
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
More details
Manual helper ordering, inferred dependency order, advice-root exclusion, and generated $Muzzle bytecode remained stable under missing-class, duplicate-advice, and additional-advice inputs. The extraction remains build-time-only and adds no runtime hot path.
📊 Validated against 8 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 8588c00 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
What Does This Do
Extract advice crawl and helper resolution logic from
MuzzleGeneratortoHelperResolver. TheHelperResolveris called once per module. Then from this result,MuzzleGeneratorthen emits both the$Muzzlereference and module'shelperClassNames().Motivation
Put crawl-related logic in one place - this makes it easier to read and test.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]