Skip to content

Move advice crawl and helper resolution to separate resolver - #12191

Open
sarahchen6 wants to merge 2 commits into
sarahchen6/infer-helper-classes-pt-1from
sarahchen6/separate-helper-plugin
Open

Move advice crawl and helper resolution to separate resolver#12191
sarahchen6 wants to merge 2 commits into
sarahchen6/infer-helper-classes-pt-1from
sarahchen6/separate-helper-plugin

Conversation

@sarahchen6

@sarahchen6 sarahchen6 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Extract advice crawl and helper resolution logic from MuzzleGenerator to HelperResolver. The HelperResolver is called once per module. Then from this result, MuzzleGenerator then emits both the $Muzzle reference and module's helperClassNames().

Motivation

Put crawl-related logic in one place - this makes it easier to read and test.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@datadog-datadog-us1-prod

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.00 s 13.95 s [-0.4%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent 12.99 s 12.94 s [-0.5%; +1.2%] (no difference)
startup:petclinic:appsec:Agent 17.42 s 17.29 s [-0.1%; +1.7%] (no difference)
startup:petclinic:iast:Agent 17.51 s 17.59 s [-1.3%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 17.36 s 17.44 s [-1.5%; +0.6%] (no difference)
startup:petclinic:sca:Agent 17.40 s 16.62 s [+0.4%; +8.9%] (maybe worse)
startup:petclinic:tracing:Agent 16.60 s 16.22 s [-2.1%; +6.8%] (no difference)

Commit: 8588c007 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@sarahchen6
sarahchen6 force-pushed the sarahchen6/separate-helper-plugin branch 2 times, most recently from 98fc668 to 1e102d2 Compare August 11, 2026 19:33
@sarahchen6
sarahchen6 changed the base branch from sarahchen6/use-array to sarahchen6/infer-helper-classes-pt-1 August 11, 2026 19:33
@sarahchen6
sarahchen6 force-pushed the sarahchen6/separate-helper-plugin branch from 1e102d2 to 028cada Compare August 11, 2026 21:35
@sarahchen6
sarahchen6 marked this pull request as ready for review August 12, 2026 15:09
@sarahchen6
sarahchen6 requested a review from a team as a code owner August 12, 2026 15:09
@sarahchen6
sarahchen6 requested a review from ygree August 12, 2026 15:09
@dd-octo-sts

dd-octo-sts Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@sarahchen6 sarahchen6 added type: feature Enhancements and improvements comp: tooling Build & Tooling labels Aug 12, 2026

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

Manual helper ordering, inferred dependency order, advice-root exclusion, and generated $Muzzle bytecode remained stable under missing-class, duplicate-advice, and additional-advice inputs. The extraction remains build-time-only and adds no runtime hot path.

Was this helpful? React 👍 or 👎

📊 Validated against 8 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 8588c00 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant