docs: fix broken source links in instrumentation guides - #12267
Closed
vaibhav8a wants to merge 1 commit into
Closed
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7319b5358d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Current-tree links: google-http-client -> google-http-client-1.19, and dd-java-agent/testing -> dd-java-agent/instrumentation-testing. Pinned-SHA links at 5307b46 are deliberately left on the old path, since that snapshot predates the module rename.
vaibhav8a
force-pushed
the
fix-broken-doc-links
branch
from
August 24, 2026 07:41
7319b53 to
6b54631
Compare
Contributor
|
👋 Hey @vaibhav8a, thanks for the fix and contribution! I've mirrored this PR in #12399 and will merge it in ASAP. 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes links in the instrumentation guides that point at paths which no longer exist. Verified against the current tree on
master.Current-tree links corrected
dd-java-agent/instrumentation/google-http-client/→google-http-client-1.19/(the module directory carries the version suffix) — 4 links indocs/add_new_instrumentation.md, including the bare directory link on line 4.dd-java-agent/testing/→dd-java-agent/instrumentation-testing/for the shared test base classes —add_new_instrumentation.mdandhow_instrumentations_work.md.Pinned-SHA links deliberately NOT changed
Lines 191–192 link into the fixed snapshot
5307b46fe3956f0d1f09f84e1dab580af222ddc5. That commit predates the rename, so the correct path there is stillgoogle-http-client. I verified both against raw.githubusercontent at that SHA:.../instrumentation/google-http-client/....../instrumentation/google-http-client-1.19/...My first revision wrongly rewrote those two as well, which would have broken them. Thanks to the review bot for catching it — now reverted, so historical links resolve inside their snapshot and current-tree links resolve on
master.