Skip to content

Add IDM as co-owners for all instrumentations - #12276

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
sarahchen6/instrumentation-updates
Aug 25, 2026
Merged

Add IDM as co-owners for all instrumentations#12276
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
sarahchen6/instrumentation-updates

Conversation

@sarahchen6

@sarahchen6 sarahchen6 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Add IDM as co-owners for all instrumentations to ease reviewing PRs such as #12266 that update instrumentation versions -- with this change, we should only need one review from an IDM team member instead of reviews from each team with updated instrumentation versions.

Also split all gradle.lockfiles between IDM (instrumentation-related) and LP (other) for similar reasons.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@sarahchen6 sarahchen6 added the type: feature Enhancements and improvements label Aug 24, 2026
@sarahchen6
sarahchen6 requested a review from a team as a code owner August 24, 2026 16:00
@sarahchen6 sarahchen6 added the tag: no release notes Changes to exclude from release notes label Aug 24, 2026
@sarahchen6
sarahchen6 requested review from PerfectSlayer and removed request for a team August 24, 2026 16:00
@sarahchen6 sarahchen6 added the comp: tooling Build & Tooling label Aug 24, 2026
@sarahchen6
sarahchen6 requested review from a team and AlexeyKuznetsov-DD August 24, 2026 16:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f835f793e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/CODEOWNERS Outdated
Comment thread .github/CODEOWNERS Outdated
Comment thread .github/CODEOWNERS Outdated

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

The final build file rules remove the IDM owner from instrumentation build files. Instrumentation version changes can still require a review from the language platform team.

Open Bits AI session

🤖 Datadog Autotest · Commit f835f79 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

Comment thread .github/CODEOWNERS Outdated
@datadog-official

datadog-official Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 58.79% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 95c19ca | Docs | View more details | Give us feedback!

Comment thread .github/CODEOWNERS Outdated
@dd-octo-sts

dd-octo-sts Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.89 s 14.62 s [+0.9%; +2.7%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.61 s 13.75 s [-1.8%; -0.3%] (maybe better)
startup:petclinic:appsec:Agent 16.98 s 16.67 s [+1.0%; +2.7%] (significantly worse)
startup:petclinic:iast:Agent 16.91 s 16.98 s [-1.1%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.70 s 16.76 s [-1.6%; +0.9%] (no difference)
startup:petclinic:sca:Agent 16.84 s 16.59 s [+0.4%; +2.5%] (maybe worse)
startup:petclinic:tracing:Agent 16.21 s 16.05 s [+0.1%; +1.9%] (maybe worse)

Commit: 95c19ca3 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@sarahchen6 sarahchen6 changed the title Add IDM as CODEOWNERS for all instrumentations Add IDM as co-owners for all instrumentations Aug 24, 2026
Base automatically changed from sarahchen6/update-codeowners to master August 24, 2026 18:49

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

The final generic build file rules override the earlier instrumentation rule. Instrumentation build files do not request IDM review, so the main ownership goal is incomplete.

Open Bits AI session

🤖 Datadog Autotest · Commit 4f1d304 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

Comment thread .github/CODEOWNERS
@sarahchen6 sarahchen6 added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Aug 25, 2026
@sarahchen6

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 25, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-25 19:39:05 UTC ℹ️ Start processing command /merge


2026-08-25 19:39:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-08-25 20:10:56 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for c91327b:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@sarahchen6

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 25, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-25 20:13:16 UTC ℹ️ Start processing command /merge


2026-08-25 20:13:20 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-08-25 21:06:36 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit d13fca0 into master Aug 25, 2026
600 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the sarahchen6/instrumentation-updates branch August 25, 2026 21:06
@github-actions github-actions Bot added this to the 1.66.0 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants