More ignores#1289
Closed
mar-kolya wants to merge 15 commits into
Closed
Conversation
mar-kolya
force-pushed
the
mar-kolya/more-ignores
branch
3 times, most recently
from
eea0146 to
951f2c8
Compare
mar-kolya
force-pushed
the
mar-kolya/more-ignores
branch
from
951f2c8 to
b8b1938
Compare
Looks like it has lots of runnables sprinkled all over the place
It has some runnables and it is not very big
mar-kolya
force-pushed
the
mar-kolya/more-ignores
branch
from
b8b1938 to
98395ee
Compare
Otherwise `Runnable` may define `call` method leading to instrumentation exception. See `org.h2.util.Task` as an example.
Grpc lib uses executors to schedule to idle/delayed tasks. These tasks become part of the trace if async propagation is enabled causing trace to never finish.
mar-kolya
force-pushed
the
mar-kolya/more-ignores
branch
from
98395ee to
341109c
Compare
mar-kolya
force-pushed
the
mar-kolya/more-ignores
branch
from
341109c to
9ea57bf
Compare
Contributor
|
This was merged with #1293 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.