Scale back ignores#1293
Merged
Merged
Conversation
Contributor
|
@mar-kolya see #1301 |
mar-kolya
force-pushed
the
mar-kolya/scale-back-ignores
branch
from
81acf58 to
39bd80d
Compare
Looks like it has lots of runnables sprinkled all over the place
It has some runnables and it is not very big
Otherwise `Runnable` may define `call` method leading to instrumentation exception. See `org.h2.util.Task` as an example.
Since we include concurrent instrumentation for all instrumentatin projects now there is no point in including it in every instrumentation.
Classloading instrument core JDK classes so we should make sure this doesn't have bad effects on other instrumentations.
mar-kolya
force-pushed
the
mar-kolya/scale-back-ignores
branch
from
39bd80d to
46b776f
Compare
tylerbenson
approved these changes
Mar 6, 2020
| testCompile project(':dd-java-agent:instrumentation:java-concurrent') | ||
| // FIXME: we should enable this, but currently this fails tests for google http client | ||
| //testCompile project(':dd-java-agent:instrumentation:http-url-connection') | ||
| testCompile project(':dd-java-agent:instrumentation:classloading') |
Contributor
There was a problem hiding this comment.
nice call adding this too.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include
java-concurrentinstrumentation in all instrumentations when running tests.This has uncovered bugs in
java-concurrentinstrumentation andgrpcinstrumentation which should also be fixed by this PR.