replace collection.size() > 0 with not collection.isEmpty()#1420
Merged
Conversation
devinsba
approved these changes
May 1, 2020
Contributor
devinsba
left a comment
devinsba
left a comment
There was a problem hiding this comment.
Am I right that the benefit here is that size() on some collections is a linear time operation?
Contributor
Author
|
Yes, it virtually never matters but if you don't know/control the collection implementation it's just risk averse to prefer |
Contributor
|
Nice. This has actually bitten us once or twice before -- and would definitely like to see us get in the habit of using isEmpty() rather size() > 0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to enforce this with static analysis.