Skip to content

replace collection.size() > 0 with not collection.isEmpty() #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardstartin merged 1 commit into from
May 1, 2020
Merged

replace collection.size() > 0 with not collection.isEmpty() #1420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/Instrumenter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public Default(final String instrumentationName, final String... additionalNames
instrumentationPrimaryName = instrumentationName;

enabled = Config.get().isIntegrationEnabled(instrumentationNames, defaultEnabled());
if (contextStore().size() > 0) {
if (!contextStore().isEmpty()) {
contextProvider = new FieldBackedProvider(this);
} else {
contextProvider = NoopContextProvider.INSTANCE;
Expand Down
2 changes: 1 addition & 1 deletion ...ent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/MuzzleVersionScanPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ private static String prettyPrint(final String prefix, final Reference ref) {
if (ref.getSuperName() != null) {
builder.append(" extends<").append(ref.getSuperName()).append(">");
}
if (ref.getInterfaces().size() > 0) {
if (!ref.getInterfaces().isEmpty()) {
builder.append(" implements ");
for (final String iface : ref.getInterfaces()) {
builder.append(" <").append(iface).append(">");
Expand Down
2 changes: 1 addition & 1 deletion ...n/hibernate/src/main/java/datadog/trace/instrumentation/hibernate/HibernateDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public String entityName(final Object entity) {
} else if (annotations.contains("javax.persistence.Entity")) {
// We were given an instance of an entity.
name = entity.getClass().getName();
} else if (entity instanceof List && ((List) entity).size() > 0) {
} else if (entity instanceof List && !((List) entity).isEmpty()) {
// We have a list of entities.
name = entityName(((List) entity).get(0));
}
Expand Down