Skip to content

Conversation

@janine-c
Copy link
Contributor

What does this PR do? What is the motivation?

This is a new PR, replicating changes already approved in #26466 - just with a branch name without a typo in it, so our flows work 😬

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@github-actions
Copy link
Contributor

@jhgilbert jhgilbert self-assigned this Nov 26, 2024
Copy link
Contributor

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with suggestions, please take whatever helps and disregard the rest. Thanks!

In addition to setting up CSM with or without an Agent, you can also set it up without Infrastructure Monitoring.

**Tip**: In your CSM settings, set up [resource evaluation filters][1] to limit the number of hosts you need security on.
<!-- ## Set up CSM on your AWS account -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this comment can be deleted now

1. To turn off infrastructure monitoring, under the selected account number, on the **Metric Collection** tab, click the **disable metric collection** link. Then, click **Disable Metric Collection** to confirm.

If you don't see the required account, add it by clicking **Add AWS Account(s)** and following the onscreen prompts.
1. To turn off infrastructure monitoring on a given account, under the selected account number, on the **Metric Collection** tab, click the **disable metric collection** link. Then, click **Disable Metric Collection** to confirm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might put the tab name first, if it's something they would need to switch to. Maybe something like "To turn off infrastructure monitoring on a given account, navigate to the Metric Collection tab. ..."

## Set up CSM on your Azure subscription
**Note**: In your CSM settings, set up [resource evaluation filters][1] to limit the number of hosts you need security on.

<!-- ## Set up CSM on your Azure subscription
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen us commit commented-out content to prod before, so just wanted to flag that. I don't see why it hurts anything and I wouldn't expect it to get picked up in search -- it might be something other people do and I just haven't encountered it!

@janine-c
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 26, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-26 19:30:07 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-26 19:46:35 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 9m.

@dd-mergequeue dd-mergequeue bot merged commit 76743c4 into master Nov 26, 2024
16 of 21 checks passed
@dd-mergequeue dd-mergequeue bot deleted the janine.chan/docs-9522-csm-without-infra-monitoring-edits branch November 26, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants