-
Notifications
You must be signed in to change notification settings - Fork 1.2k
CSM without infra monitoring edits - now with fixed branch name! #26502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSM without infra monitoring edits - now with fixed branch name! #26502
Conversation
Preview links (active after the
|
jhgilbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with suggestions, please take whatever helps and disregard the rest. Thanks!
| In addition to setting up CSM with or without an Agent, you can also set it up without Infrastructure Monitoring. | ||
|
|
||
| **Tip**: In your CSM settings, set up [resource evaluation filters][1] to limit the number of hosts you need security on. | ||
| <!-- ## Set up CSM on your AWS account --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this comment can be deleted now
| 1. To turn off infrastructure monitoring, under the selected account number, on the **Metric Collection** tab, click the **disable metric collection** link. Then, click **Disable Metric Collection** to confirm. | ||
|
|
||
| If you don't see the required account, add it by clicking **Add AWS Account(s)** and following the onscreen prompts. | ||
| 1. To turn off infrastructure monitoring on a given account, under the selected account number, on the **Metric Collection** tab, click the **disable metric collection** link. Then, click **Disable Metric Collection** to confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might put the tab name first, if it's something they would need to switch to. Maybe something like "To turn off infrastructure monitoring on a given account, navigate to the Metric Collection tab. ..."
| ## Set up CSM on your Azure subscription | ||
| **Note**: In your CSM settings, set up [resource evaluation filters][1] to limit the number of hosts you need security on. | ||
|
|
||
| <!-- ## Set up CSM on your Azure subscription |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen us commit commented-out content to prod before, so just wanted to flag that. I don't see why it hurts anything and I wouldn't expect it to get picked up in search -- it might be something other people do and I just haven't encountered it!
|
/merge |
Devflow running:
|
What does this PR do? What is the motivation?
This is a new PR, replicating changes already approved in #26466 - just with a branch name without a typo in it, so our flows work 😬
Merge instructions
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes