RUM-12403 Adds documentation for iOS manual keeping/dropping traces.#34163
RUM-12403 Adds documentation for iOS manual keeping/dropping traces.#34163
Conversation
Preview links (active after the
|
65366b7 to
2130d8a
Compare
2130d8a to
07e8283
Compare
maycmlee
left a comment
There was a problem hiding this comment.
Some suggestions and a question
| {{< /tabs >}} | ||
|
|
||
| 8. (Optional) To distribute traces between your environments, for example frontend - backend, you can either do it manually or leverage our auto instrumentation. In both cases, you can opt to inject the trace context into all requests or only into the sampled ones. A sampling of 100% is applied by default. | ||
| 8. (Optional) Override a sampling decision by forcing a trace to be kept or dropped. For example, always keep a trace of a critical transaction, or always drop unnecessary, repetitive traces. |
There was a problem hiding this comment.
| 8. (Optional) Override a sampling decision by forcing a trace to be kept or dropped. For example, always keep a trace of a critical transaction, or always drop unnecessary, repetitive traces. | |
| 8. (Optional) Override a sampling decision by forcing a trace to be kept or dropped. For example, always keep a critical transaction's trace, or always drop unnecessary, repetitive traces. |
| 8. (Optional) To distribute traces between your environments, for example frontend - backend, you can either do it manually or leverage our auto instrumentation. In both cases, you can opt to inject the trace context into all requests or only into the sampled ones. A sampling of 100% is applied by default. | ||
| 8. (Optional) Override a sampling decision by forcing a trace to be kept or dropped. For example, always keep a trace of a critical transaction, or always drop unnecessary, repetitive traces. | ||
|
|
||
| Manually keep a trace: |
There was a problem hiding this comment.
Are these commands the user runs?
| Manually keep a trace: | |
| To manually keep a trace: |
There was a problem hiding this comment.
They are APIs, not commands. The APIs are similar to https://docs.datadoghq.com/tracing/trace_pipeline/ingestion_mechanisms/?tab=java#force-keep-and-drop but in the context of the iOS SDK (agent-less).
| 8. (Optional) To distribute traces between your environments, for example frontend - backend, you can either do it manually or leverage our auto instrumentation. In both cases, you can opt to inject the trace context into all requests or only into the sampled ones. A sampling of 100% is applied by default. | ||
| 8. (Optional) Override a sampling decision by forcing a trace to be kept or dropped. For example, always keep a trace of a critical transaction, or always drop unnecessary, repetitive traces. | ||
|
|
||
| Manually keep a trace: |
There was a problem hiding this comment.
Right now this section looks like it's not part of step 8. Indenting the text and tabs will fix this. Let me know if you need any help!
| {{< /tabs >}} | ||
|
|
||
| <div class="alert alert-danger"> | ||
| Always call `keepTrace()` or `dropTrace()` on a root span before child spans are created, and before any context propagation. Otherwise, the system can't ensure consistency, resulting in partial traces being ingested. |
There was a problem hiding this comment.
| Always call `keepTrace()` or `dropTrace()` on a root span before child spans are created, and before any context propagation. Otherwise, the system can't ensure consistency, resulting in partial traces being ingested. | |
| Always call <code>keepTrace()</code> or <code>dropTrace()</code> on a root span before child spans are created, and before any context propagation. Otherwise, the system can't ensure consistency, resulting in partial traces being ingested. |
| Always call `keepTrace()` or `dropTrace()` on a root span before child spans are created, and before any context propagation. Otherwise, the system can't ensure consistency, resulting in partial traces being ingested. | ||
| </div> | ||
|
|
||
| 9. (Optional) To distribute traces between your environments, for example frontend - backend, you can either do it manually or leverage our auto instrumentation. In both cases, you can opt to inject the trace context into all requests or only into the sampled ones. A sampling of 100% is applied by default. |
There was a problem hiding this comment.
| 9. (Optional) To distribute traces between your environments, for example frontend - backend, you can either do it manually or leverage our auto instrumentation. In both cases, you can opt to inject the trace context into all requests or only into the sampled ones. A sampling of 100% is applied by default. | |
| 9. (Optional) To distribute traces between your environments, for example from frontend to backend, you can either do it manually or use auto instrumentation. In both cases, you can opt to inject the trace context into all requests or only into the sampled ones. A sampling of 100% is applied by default. |
There was a problem hiding this comment.
I applied your suggestions. However, the indenting is now different from the rest of the page… let me know if I should fix the entire page, or revert it to make it consistent. FWIW it looks way better the way you suggested, I myself had trouble reading the previously step 8 (now, 9) and making sense of what was part of it and what wasn't.
* indent steps * fix lines
What does this PR do? What is the motivation?
Documenting iOS SDK APIs for manually keeping and dropping traces.
Merge readiness: