Clarify that RUM geo.* attributes are derived from client IP, not device GPS - #36213
Merged
yuandesu merged 5 commits intoApr 27, 2026
Merged
Conversation
yuandesu
force-pushed
the
yuandesu/clarify-rum-geo-derived-from-client-ip
branch
2 times, most recently
from
April 23, 2026 02:45
99aa236 to
11cb958
Compare
github-actions
Bot
added
Architecture
yuandesu
force-pushed
the
yuandesu/clarify-rum-geo-derived-from-client-ip
branch
from
April 23, 2026 03:04
11cb958 to
0a4fd89
Compare
kikoveiga
approved these changes
Apr 23, 2026
yuandesu
force-pushed
the
yuandesu/clarify-rum-geo-derived-from-client-ip
branch
from
April 23, 2026 14:50
0a4fd89 to
08e98f3
Compare
mariedm
approved these changes
Apr 23, 2026
iadjivon
reviewed
Apr 23, 2026
iadjivon
left a comment
iadjivon
left a comment
Contributor
There was a problem hiding this comment.
Hi there,
Added some suggestions and a clarifying question here.
Thanks!
domalessi
approved these changes
Apr 23, 2026
Contributor
|
Whoops - I approved on behalf of |
yuandesu
force-pushed
the
yuandesu/clarify-rum-geo-derived-from-client-ip
branch
from
April 24, 2026 04:56
08e98f3 to
e225455
Compare
yuandesu
force-pushed
the
yuandesu/clarify-rum-geo-derived-from-client-ip
branch
from
April 24, 2026 05:02
e225455 to
9e73e04
Compare
iadjivon
reviewed
Apr 24, 2026
iadjivon
reviewed
Apr 24, 2026
iadjivon
approved these changes
Apr 24, 2026
iadjivon
left a comment
iadjivon
left a comment
Contributor
There was a problem hiding this comment.
Added a quick note but approved this!
Thanks so much for the conversation about this!
Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>
Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>
estherk15
pushed a commit
that referenced
this pull request
May 4, 2026
…ice GPS (#36213) * Clarify that RUM geo.* attributes are resolved from client IP, not device GPS * Update layouts/shortcodes/mdoc/en/sdk/data_collected/android.mdoc.md Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com> * Update layouts/shortcodes/mdoc/en/sdk/data_collected/ios.mdoc.md Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com> --------- Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Users have reported that
geo.cityattributes shows a location different from where their device physically is — particularly on mobile (SIM) connections.After confirming with the engineering team, it is clear that the Android/iOS SDK does not access the device's GPS or OS location API. All
geo.*attributes are resolved server-side from the client IP address on the intake connection.This PR adds a clarifying sentence to the Geo-location section in the Android/iOS data collected pages to make this behavior explicit, helping users understand why
geo.*may reflect a carrier's gateway location rather than the device's actual location on mobile connections.Changes made to:
layouts/shortcodes/mdoc/en/sdk/data_collected/android.mdoc.mdlayouts/shortcodes/mdoc/en/sdk/data_collected/ios.mdoc.mdMerge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
AI assistance
Used Claude Code for initial draft and update.
Additional notes