Add python pub/sub docs - #39230
Conversation
… the same section for node
This comment has been minimized.
This comment has been minimized.
maycmlee
left a comment
There was a problem hiding this comment.
Just a small suggestion, otherwise looks good
Co-authored-by: May Lee <may.lee@datadoghq.com>
maycmlee
left a comment
There was a problem hiding this comment.
@pablomartinezbernardo Thanks for using the general reuse shortcode! Left a comment about the links.
maycmlee
left a comment
There was a problem hiding this comment.
Thanls @pablomartinezbernardo! Just wanted to confirm one thing.
|
|
||
| {{% svl-tracing-env %}} | ||
|
|
||
| ## Distributed tracing with Pub/Sub |
There was a problem hiding this comment.
Just want to confirm that you didn't want to add the shortcode here.
There was a problem hiding this comment.
Correct, this is because of my "2. Remove “Distributed tracing with Pub/Sub” from Cloud Run Jobs" comment in the PR description: This should not have ever been included in cloud run jobs
maycmlee
left a comment
There was a problem hiding this comment.
Ah okay, thanks! Feel free to merge when ready!
What does this PR do? What is the motivation?
Add python pub/sub docs by extracting the content to a shortcode. Also, fix 2 issues (changing it in the shortcode, and therefore in the preexisting node docs):
1. Use --transport-topic for existing Pub/Sub topics
The previous Eventarc examples used:
--event-filters="type=google.cloud.pubsub.topic.v1.messagePublished"
--event-filters="topic=projects/my-project/topics/orders"
They now use:
--event-filters="type=google.cloud.pubsub.topic.v1.messagePublished"
--transport-topic=projects/my-project/topics/orders
The distinction is important:
Sources:
2. Remove “Distributed tracing with Pub/Sub” from Cloud Run Jobs
Both parts of the section assumed a request-serving Cloud Run resource:
The direct subscription example configured an HTTP endpoint:
--push-endpoint=https://order-processor-xyz.run.app/pubsub
The Eventarc Standard example configured:
--destination-run-service=order-processor
Neither applies to a Cloud Run Job:
Run Jobs guide (https://docs.cloud.google.com/eventarc/advanced/docs/quickstarts/publish-events-cloud-run-job)
Merge readiness
For Datadog employees:
<name>/<description>convention and include the forward slash (/). If you've already created your PR with an incorrect branch name, please rename your branch and open a fresh PR./reviewto run an automated check that catches common issues before a Documentation team member reviews your PR.AI assistance
Additional notes