Fix logic when other params are passed into instances - #13409
Merged
Conversation
ghost
added
the
steveny91
changed the title
steveny91
changed the title
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
yzhan289
reviewed
Nov 29, 2022
yzhan289
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix an issue in which when other params are being passed into the instance, the check would throw an error. I originally iterated over the instances expecting there to be endpoints only when setting up custom transformers. Also added a more robust test instance that would reflect what people would use if they would use this check to the tests.