Skip to content

Fix the url descriptions in the config file - #14280

Merged
FlorentClarret merged 1 commit into
masterfrom
florentclarret/coredns/fix_config_description
Apr 3, 2023
Merged

Fix the url descriptions in the config file#14280
FlorentClarret merged 1 commit into
masterfrom
florentclarret/coredns/fix_config_description

Conversation

@FlorentClarret

@FlorentClarret FlorentClarret commented Mar 30, 2023

Copy link
Copy Markdown
Member

What does this PR do?

Fix the prometheus_url and openmetrics_endpoint descriptions.

Motivation

There's no openmetrics_url config option (not even as an alias), only openmetrics_endpoint.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@FlorentClarret
FlorentClarret requested review from a team as code owners March 30, 2023 15:06
@FlorentClarret FlorentClarret changed the title Fix the url descriptions Fix the url descriptions in the config file Mar 30, 2023
@github-actions

github-actions Bot commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit b45a813.

drichards-87
drichards-87 previously approved these changes Mar 30, 2023
View reviewed changes

@drichards-87 drichards-87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from Docs.

@FlorentClarret
FlorentClarret force-pushed the florentclarret/coredns/fix_config_description branch from b45a813 to b5f326a Compare March 30, 2023 15:25
@codecov

codecov Bot commented Mar 30, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #14280 (b5f326a) into master (c4967b0) will decrease coverage by 0.01%.
The diff coverage is n/a.

Flag Coverage Δ
coredns 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret
FlorentClarret merged commit 76d52cb into master Apr 3, 2023
@FlorentClarret
FlorentClarret deleted the florentclarret/coredns/fix_config_description branch April 3, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ofek ofek ofek approved these changes
@AliDatadog AliDatadog AliDatadog approved these changes
@drichards-87 drichards-87 Awaiting requested review from drichards-87

Assignees

No one assigned

Labels

changelog/no-changelog documentation integration/coredns

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FlorentClarret @ofek @drichards-87 @AliDatadog @yzhan289