Skip to content

snmp: Fix tests with agent_host tag#21405

Merged
FlorianVeaux merged 2 commits into
masterfrom
flo/fix_snmp_tests
Sep 22, 2025
Merged

snmp: Fix tests with agent_host tag#21405
FlorianVeaux merged 2 commits into
masterfrom
flo/fix_snmp_tests

Conversation

@FlorianVeaux

Copy link
Copy Markdown
Member

Tests were failing since we updated the Agent to emit the agent_host tag by default

NouhaManai96
NouhaManai96 previously approved these changes Sep 19, 2025
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Recommendation: Add qa/skip-qa Label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

TCheruy
TCheruy previously approved these changes Sep 19, 2025
@temporal-github-worker-1
temporal-github-worker-1 Bot dismissed stale reviews from NouhaManai96 and TCheruy September 19, 2025 15:00

Review from NouhaManai96 is dismissed. Related teams and files:

  • ndm-core
    • snmp/tests/test_e2e_core.py
    • snmp/tests/test_e2e_core_profiles/test_profile_servertech_pdu3.py
    • snmp/tests/test_e2e_core_profiles/utils.py
    • snmp/tests/test_parsing.py

Review from TCheruy is dismissed. Related teams and files:

  • ndm-core
    • snmp/tests/test_e2e_core.py
    • snmp/tests/test_e2e_core_profiles/test_profile_servertech_pdu3.py
    • snmp/tests/test_e2e_core_profiles/utils.py
    • snmp/tests/test_parsing.py
@codecov

codecov Bot commented Sep 19, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.00%. Comparing base (70e6d29) to head (8e9ab2f).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FlorianVeaux
FlorianVeaux added this pull request to the merge queue Sep 22, 2025
Merged via the queue into master with commit 91460ce Sep 22, 2025
37 of 38 checks passed
@FlorianVeaux
FlorianVeaux deleted the flo/fix_snmp_tests branch September 22, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants