Always use client cursor when connecting to pgbouncer - #21649
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
eric-weaver
approved these changes
Oct 14, 2025
eric-weaver
left a comment
eric-weaver
left a comment
Contributor
There was a problem hiding this comment.
Fix looks good to me. The previous connection arg combinations that would skip setting ClientCursor factory now look always covered 👍
Kyle-Neale
approved these changes
Oct 14, 2025
datadog-agent-integrations-bot Bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
* Always use client cursor * Add changelog (cherry picked from commit c1555a7)
3 tasks
github-actions Bot
pushed a commit
to bskinny/integrations-core
that referenced
this pull request
Oct 14, 2025
* Always use client cursor * Add changelog c1555a7
Kyle-Neale
pushed a commit
that referenced
this pull request
Oct 14, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR ensures we always use ClientCursor (and simple query protocol) when connecting to pgbouncer.
Motivation
Customers connecting via the admin console could see an error reported here: DataDog/datadog-agent#41463
psycopg3 docs: https://www.psycopg.org/psycopg3/docs/advanced/cursors.html#simple-query-protocol
thanks @eric-weaver!
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged