Fix and optimize the Slurm integration - #24521
Draft
steveny91 wants to merge 3 commits into
Draft
Conversation
Contributor
|
Contributor
Validation Report
Run Passed validations (20)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hardens the
slurmintegration against Slurm version drift (validated against Slurm 25.05 on a live CoreWeave SUNK cluster) and fixes a batch of latent correctness, robustness, metadata, and test-quality issues surfaced by a multi-pass review.Motivation
I got access to a limited time slurm cluster and wanted to test the integration against it. Fixes some parsing errors and slight optimization to ensure crashes and timeout are better handled.
Fixed some dashboards queries that were incorrectly marked for a metric that wasn't emitted. Same for the metadata.csv