Skip to content

Fix and optimize the Slurm integration - #24521

Draft
steveny91 wants to merge 3 commits into
masterfrom
sy/slurm-bobofix
Draft

Fix and optimize the Slurm integration#24521
steveny91 wants to merge 3 commits into
masterfrom
sy/slurm-bobofix

Conversation

@steveny91

@steveny91 steveny91 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Hardens the slurm integration against Slurm version drift (validated against Slurm 25.05 on a live CoreWeave SUNK cluster) and fixes a batch of latent correctness, robustness, metadata, and test-quality issues surfaced by a multi-pass review.

Motivation

I got access to a limited time slurm cluster and wanted to test the integration against it. Fixes some parsing errors and slight optimization to ensure crashes and timeout are better handled.

Fixed some dashboards queries that were incorrectly marked for a metric that wasn't emitted. Same for the metadata.csv

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests  Code Coverage

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

Check PR | run / Check PR changelog   View in Datadog   GitHub Actions

Validate repository | Run Validations / Validate   View in Datadog   GitHub Actions

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 92.57%
Overall Coverage: 93.58%

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: faa3bad | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Validation Report

Validation Description Status
qa-label Validate the pull request declares whether it needs QA for the next Agent release

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant