Deploy Kubernetes Agent E2E backend with Helm - #24647
Closed
nubtron wants to merge 2 commits into
Closed
Conversation
Contributor
Validation ReportAll 21 validations passed. Show details
|
This comment has been minimized.
This comment has been minimized.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the Kubernetes Agent backend's hand-written Pod and RBAC resources with the official Datadog Helm chart (
datadog3.231.6) and its Node Agent DaemonSet.KubernetesAgentas the publicAgentInterfacebackend and preserves the existing package/configuration anddd_agent_checkflows.Motivation
The backend introduced by #24639 proves real in-cluster Kubernetes Autodiscovery, but its custom Pod/RBAC deployment is only an approximation of production. Using the pinned official chart exercises the production-shaped Node Agent DaemonSet, chart RBAC, labels, volumes, image mapping, and lifecycle while retaining the intentionally single-node E2E command semantics.
Validation
hatch run test -q tests/e2e/agent tests/cli/env— 164 passed, 2 expected skipsddev --no-interactive test -fs velero— passedddev env test --base velero py3.13— static and discovery E2Es passed against the Helm DaemonSet, including uninstall and Kind cleanupagentcontainer, no duplicate env keys, no Operator/Cluster Agent/CRDs, node affinity, private DogStatsD socket, bounded labels, owner-labeled RBAC, and local probesThe aggregate local lint hook could not create its Python 3.14 environment because this machine's Cargo toolchain cannot build
pydantic-core==2.33.2; the same pinned Ruff checks and targeted mypy were run directly.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged