Add composable deterministic task validation - #24777
Open
luisorofino wants to merge 2 commits into
Open
Conversation
3 tasks
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: dd778b6 | Docs | Datadog PR Page | Give us feedback! |
luisorofino
force-pushed
the
loa/deterministic-validations
branch
from
August 5, 2026 12:36
1d46737 to
b02384a
Compare
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b02384afe6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
3 tasks
luisorofino
marked this pull request as ready for review
August 5, 2026 15:03
This was referenced Aug 6, 2026
Validate deterministic check names before the worker turn runs instead of inside the retry loop, so a misconfigured check name fails before any tokens are spent. Give lazy reviewer-process creation failures a TaskValidationError subclass so tokens spent on prior deterministic repairs are still accounted for on failure, and extract reviewer construction into its own function.
luisorofino
force-pushed
the
loa/deterministic-validations
branch
from
August 7, 2026 09:35
c1a1d79 to
dd778b6
Compare
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds composable deterministic validation to agentic tasks without requiring an LLM reviewer.
deterministic_checks().max_goal_attemptstomax_validation_attemptsin the task model and existing flow configuration.The OpenMetrics-specific check and the TUI updates are intentionally kept out of this PR (see the stack).
Motivation
AI-7081 describes a seven-minute review-and-retry round trip caused by a deterministic label-policy miss. The framework previously coupled validation to an LLM goal reviewer, which meant phases could not cheaply reject artifacts using local, repeatable checks.
This layer introduces the generic composition and retry lifecycle so future phases can add fast checks without forcing a reviewer agent or duplicating orchestration logic.
Scoped coverage includes validation composition, deterministic-only repair and exhaustion, lazy reviewer construction, combined deterministic-plus-reviewer validation, checkpoint recording, configuration validation, and existing orchestration behavior. The focused suite passed 230 tests; Ruff and mypy also pass.
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged