Add forward metrics - #4850
Conversation
|
|
|
I got it to work by changing the configuration to use both plugins and triggering two DNS lookups. |
|
You can try including another coredns version to test in the tox file: and then adapting the test for different versions. |
|
It doesn't look like we need to test two versions, the forward plugin already existed in 1.2.0. |
therve
left a comment
There was a problem hiding this comment.
Looking good, some minor comments.
|
|
||
| DIG_ARGS = ["dig", "google.com", "@127.0.0.1", "-p", "54"] | ||
| # One lookup each for the forward and proxy plugins | ||
| DIG_ARGS = ["dig", "google.com", "@127.0.0.1", "example.com", "@127.0.0.1", "-p", "54"] |
There was a problem hiding this comment.
Can you pass "HOST" instead of "127.0.0.1" ?
| coredns_forward_response_rcode_count_total{rcode="NXDOMAIN",to="10.0.0.2:53"} 20482 | ||
| # HELP coredns_forward_sockets_open Gauge of open sockets per upstream. | ||
| # TYPE coredns_forward_sockets_open gauge | ||
| coredns_forward_sockets_open{to="10.0.0.2:53"} 2 |
There was a problem hiding this comment.
Is that not a useful metric to surface?
The proxy plugin is deprecated and will be replaced by forward.
|
Can this be merged now? Thanks.
|
FlorianVeaux
left a comment
There was a problem hiding this comment.
Merging and releasing the integration, thanks!
PS: The PR title is used in coredns changelog as is, I removed 'coredns' from it as we don't need to specify the integration name here.
|
This has been released and will be automatically included in Agent 6.16, until then you can install it manually with the command |
What does this PR do?
Add CoreDNS metrics for the forward plugin
Motivation
The proxy plugin is deprecated and has been removed in recent versions, with users expected to replace it with the forward plugin.
Additional Notes
I couldn't grab data for all tests: healtcheck failures are missing.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached