Use prop_assert* in property tests#1341
Closed
blt wants to merge 3 commits intoblt/introduce_tag_generator_into_otel_metrics_payloadfrom
Closed
Use prop_assert* in property tests#1341blt wants to merge 3 commits intoblt/introduce_tag_generator_into_otel_metrics_payloadfrom
blt wants to merge 3 commits intoblt/introduce_tag_generator_into_otel_metrics_payloadfrom
Conversation
This commit adjusts our use of assertions in property tests to make use of the macro provided by proptest. This gives that rig a little more information and makes debugging for us a little better. It also is going to work with --release flipped on. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
This was referenced May 1, 2025
Collaborator
Author
Collaborator
Author
|
Interesting idea, too intrusive. |
This was referenced May 1, 2025
Closed
This was referenced May 12, 2025
This was referenced May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit adjusts our use of assertions in property tests to make
use of the macro provided by proptest. This gives that rig a little
more information and makes debugging for us a little better. It also
is going to work with --release flipped on.
REF SMPTNG-659