Conversation
Collaborator
Author
blt
force-pushed
the
blt/update_payloadtool_block_cache_creation_to_have_additional_telemetry
branch
2 times, most recently
from
fd7db4e to
7f3240e
Compare
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
This was referenced May 12, 2025
blt
force-pushed
the
blt/update_payloadtool_block_cache_creation_to_have_additional_telemetry
branch
2 times, most recently
from
a401c76 to
a002707
Compare
blt
changed the base branch from
graphite-base/1349
to
blt/ignore_claude_code_tool_private_directory
blt
force-pushed
the
blt/update_payloadtool_block_cache_creation_to_have_additional_telemetry
branch
from
a002707 to
d773c5c
Compare
blt
force-pushed
the
blt/ignore_claude_code_tool_private_directory
branch
from
71f592e to
44e1321
Compare
blt
force-pushed
the
blt/ignore_claude_code_tool_private_directory
branch
2 times, most recently
from
bb74c62 to
e35ee58
Compare
blt
force-pushed
the
blt/update_payloadtool_block_cache_creation_to_have_additional_telemetry
branch
from
d773c5c to
c607f60
Compare
blt
force-pushed
the
blt/ignore_claude_code_tool_private_directory
branch
from
e35ee58 to
7191dd5
Compare
blt
force-pushed
the
blt/update_payloadtool_block_cache_creation_to_have_additional_telemetry
branch
from
c607f60 to
09bcc77
Compare
GeorgeHahn
approved these changes
May 12, 2025
blt
changed the base branch from
blt/ignore_claude_code_tool_private_directory
to
graphite-base/1349
blt
force-pushed
the
blt/update_payloadtool_block_cache_creation_to_have_additional_telemetry
branch
from
09bcc77 to
8d8e833
Compare
blt
force-pushed
the
blt/update_payloadtool_block_cache_creation_to_have_additional_telemetry
branch
from
8d8e833 to
309d3dd
Compare
This commit adds telemetry to the payloadtool and block cache generation so that we are able to keep track of the number of rejected blocks at cache creation time. The goal is to minimize the amount of rejection and thus wasted computation. REF SMPTNG-659 Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/update_payloadtool_block_cache_creation_to_have_additional_telemetry
branch
from
309d3dd to
bcef0a7
Compare
Collaborator
Author
blt
deleted the
blt/update_payloadtool_block_cache_creation_to_have_additional_telemetry
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit adds telemetry to the payloadtool and block cache generation so
that we are able to keep track of the number of rejected blocks at cache
creation time. The goal is to minimize the amount of rejection and thus
wasted computation.
This change demonstrates that dogstatsd, as one example of a payload, does not overly reject blocks at cache creation time.
Motivation
REF SMPTNG-659