Allow lading_payload::Serialize to be mutable#1352
Merged
Conversation
This commit allows the Serialize trait defined in lading_payload to mutate itself. This will improve the ergonimics of writing a serializer that must have some form of memory, without requiring other serializers to opt into this behavior. Curiously, this did turn up two problems with dogstatsd: an aliased function and a framing bug. Both are now corrected. I'm not sure why this didn't trigger before. REF SMPTNG-659 Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Collaborator
Author
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
GeorgeHahn
approved these changes
May 12, 2025
This was referenced May 12, 2025
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit allows the Serialize trait defined in lading_payload
to mutate itself. This will improve the ergonimics of writing
a serializer that must have some form of memory, without requiring
other serializers to opt into this behavior.
Curiously, this did turn up two problems with dogstatsd: an aliased
function and a framing bug. Both are now corrected. I'm not sure
why this didn't trigger before.
Motivation
REF SMPTNG-659