Closed
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
scottopell
reviewed
Jul 3, 2025
This was referenced Jul 7, 2025
blt
force-pushed
the
blt/add_parallel_connections_to_unix_stream
branch
2 times, most recently
from
a69f29c to
15e2eb6
Compare
blt
changed the base branch from
graphite-base/1408
to
blt/fix_dogstatsd_regression_test
blt
force-pushed
the
blt/add_parallel_connections_to_unix_stream
branch
from
2975308 to
2dc22d6
Compare
scottopell
approved these changes
Jul 8, 2025
This commit ports the behavior of unix_datagram to unix_stream. Each parallel connection maintains its own separate block cache, meaning for large numbers of parallel connections startup time may be high. However users will no longer have to make independent unix_stream generators within a single configuration. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/add_parallel_connections_to_unix_stream
branch
from
2dc22d6 to
c7a3220
Compare
Collaborator
Author
|
I merged the stack weirdly, closing to rescue the separate PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit ports the behavior of unix_datagram to unix_stream. Each
parallel connection maintains its own separate block cache, meaning
for large numbers of parallel connections startup time may be high.
However users will no longer have to make independent unix_stream
generators within a single configuration.
With the parallel_connection addition to unix_stream we now must solve
the problem of high connection count causing non-trivial cache duplication.
This is done by allowing for a 'handle' on the cache which maintains a separate
index per handle, meaning we do not need to synchronize the cache indexes between
peers and peers are able to reference the singular cache.
Motivation
https://github.com/DataDog/saluki use-case