Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blt
force-pushed
the
blt/add_parallel_connections_to_unix_stream
branch
from
144fec6 to
a69f29c
Compare
blt
force-pushed
the
blt/fix_dogstatsd_regression_test
branch
from
8910efb to
e3c2a59
Compare
blt
changed the base branch from
blt/add_parallel_connections_to_unix_stream
to
graphite-base/1413
This commit fixes our prefix length calculation, triggered only when max_bytes is low. We were removing the size of a `usize` when `u32` was appropriate, as that is the proper length of the payload prefix. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/fix_dogstatsd_regression_test
branch
from
e3c2a59 to
a0b68dc
Compare
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/fix_dogstatsd_regression_test
branch
from
a0b68dc to
15e2eb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit fixes our prefix length calculation, triggered only when max_bytes
is low. We were removing the size of a
usizewhenu32was appropriate, asthat is the proper length of the payload prefix.