Allow block cache to have a 'handle' concept#1412
Merged
blt merged 3 commits intographite-base/1412from Jul 9, 2025
Merged
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blt
changed the base branch from
blt/add_parallel_connections_to_unix_stream
to
graphite-base/1412
blt
force-pushed
the
blt/allow_block_cache_to_have_a_handle_concept
branch
from
4f4df98 to
f92461d
Compare
blt
changed the base branch from
graphite-base/1412
to
blt/fix_dogstatsd_regression_test
blt
force-pushed
the
blt/allow_block_cache_to_have_a_handle_concept
branch
2 times, most recently
from
69cb9ee to
053d52d
Compare
blt
force-pushed
the
blt/fix_dogstatsd_regression_test
branch
from
8910efb to
e3c2a59
Compare
blt
changed the base branch from
blt/fix_dogstatsd_regression_test
to
graphite-base/1412
blt
force-pushed
the
blt/allow_block_cache_to_have_a_handle_concept
branch
from
053d52d to
34e9e22
Compare
blt
changed the base branch from
graphite-base/1412
to
blt/add_parallel_connections_to_unix_stream
blt
force-pushed
the
blt/allow_block_cache_to_have_a_handle_concept
branch
from
34e9e22 to
18c009e
Compare
With the parallel_connection addition to unix_stream we now must solve the problem of high connection count causing non-trivial cache duplication. This is done by allowing for a 'handle' on the cache which maintains a separate index per handle, meaning we do not need to synchronize the cache indexes between peers and peers are able to reference the singular cache. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/add_parallel_connections_to_unix_stream
branch
from
2975308 to
2dc22d6
Compare
blt
force-pushed
the
blt/allow_block_cache_to_have_a_handle_concept
branch
from
18c009e to
1846283
Compare
blt
changed the base branch from
blt/add_parallel_connections_to_unix_stream
to
graphite-base/1412
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With the parallel_connection addition to unix_stream we now must solve
the problem of high connection count causing non-trivial cache duplication.
This is done by allowing for a 'handle' on the cache which maintains a separate
index per handle, meaning we do not need to synchronize the cache indexes between
peers and peers are able to reference the singular cache.